fix: Surface neuroglancer in View Tomogram tooltip #1631
Merged
+30
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surfaces a link to the Neuroglancer quickstart guide in the View Tomogram button tooltip.
melissawm
force-pushed
the
surface-neuroglancer
branch
from
6a5999a to
c401f14
Compare
melissawm
changed the title
The tooltip was disappearing before it could be clicked.
melissawm
force-pushed
the
surface-neuroglancer
branch
from
c401f14 to
aba407d
Compare
melissawm
force-pushed
the
surface-neuroglancer
branch
from
4007b8c to
02559fb
Compare
This is not hovering right, there should be no border and the fill color should be the border color |
|
Ok - changed the PR a bit to meet the design goals which is why I re-requested a review from @rainandbare , but should be good now. My last question is I didn't see specs for the Tomograms table button, should it be left as is? e.g. https://surface-neuroglancer.cryoet.dev.si.czi.technology/runs/16849?table-tab=Tomograms
|
|
no need to change the tomogram table button! |
|
And thanks so much Melissa, this looks great!! No more feedback :))) |
rainandbare
approved these changes
Feb 25, 2025
|
Thanks @kev-zunshiwang and @rainandbare for the reviews ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1383
Closes #1283
Also addresses an issue where the tooltip was not clickable in the Runs table.
Before:
Screen.Recording.2025-02-14.at.5.07.39.PM.mov
After this PR:
Screen.Recording.2025-02-14.at.5.09.00.PM.mov