Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack component #48

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Stack component #48

merged 4 commits into from
Aug 3, 2023

Conversation

D-Lite
Copy link
Contributor

@D-Lite D-Lite commented Jun 27, 2023

Feat: stack component documentation

stackcomponent

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
vue-docs-next ✅ Ready (Inspect) Visit Preview Jul 20, 2023 10:07pm

Copy link
Collaborator

@carwack carwack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the casing of the code examples?
I'm referring to #39.
Thanks!


# Stack

Stack is a layout utility component that makes it easy to stack elements together and apply a space between them. It composes the `Flex` component.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could Flex be changed into CFlex?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Stack is a layout utility component that makes it easy to stack elements together and apply a space between them. It composes the `Flex` component.
Stack is a layout utility component that makes it easy to stack elements together and apply a space between them. It composes the `CFlex` component.

Copy link
Collaborator

@carwack carwack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes and we are good to go!


# Stack

Stack is a layout utility component that makes it easy to stack elements together and apply a space between them. It composes the `Flex` component.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Stack is a layout utility component that makes it easy to stack elements together and apply a space between them. It composes the `Flex` component.
Stack is a layout utility component that makes it easy to stack elements together and apply a space between them. It composes the `CFlex` component.

content/4.components/stack.md Outdated Show resolved Hide resolved
```html
<CStack :spacing="5">
<CBox :p="5" shadow="md" border-width="1px">
<CHeading>See the Vue</c-heading>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<CHeading>See the Vue</c-heading>
<CHeading>See the Vue</CHeading>

content/4.components/stack.md Outdated Show resolved Hide resolved
<CText :mt="4">Vue makes front-end development a breeze.</c-text>
</CBox>
<CBox :p="5" shadow="md" border-width="1px">
<CHeading>Go Nuxt!</c-heading>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<CHeading>Go Nuxt!</c-heading>
<CHeading>Go Nuxt!</CHeading>

content/4.components/stack.md Outdated Show resolved Hide resolved
content/4.components/stack.md Outdated Show resolved Hide resolved
<CText :mt="4">Vue makes front-end development a breeze.</c-text>
</CBox>
<CBox :p="5" shadow="md" border-width="1px">
<CHeading>Go Nuxt!</c-heading>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<CHeading>Go Nuxt!</c-heading>
<CHeading>Go Nuxt!</CHeading>

</CBox>
<CBox :p="5" shadow="md" border-width="1px">
<CHeading>Go Nuxt!</c-heading>
<CText :mt="4">Nuxt makes writing Vue even easier.</c-text>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<CText :mt="4">Nuxt makes writing Vue even easier.</c-text>
<CText :mt="4">Nuxt makes writing Vue even easier.</CText>

content/4.components/stack.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@carwack carwack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding this! 🚀

@carwack carwack merged commit 856c285 into chakra-ui:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants