Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex Component #45

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Flex Component #45

merged 4 commits into from
Aug 3, 2023

Conversation

D-Lite
Copy link
Contributor

@D-Lite D-Lite commented Jun 21, 2023

feat: flex component documentation

flexcomponent

@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
vue-docs-next ✅ Ready (Inspect) Visit Preview Jul 20, 2023 9:54pm

Copy link
Collaborator

@carwack carwack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the casing of the code examples?
I'm referring to #39.
Thanks!


# Flex

Flex is `Box` with `display: flex` and comes with helpful style shorthand. It renders a `div` element.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could box be changed into CBox?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Flex is `Box` with `display: flex` and comes with helpful style shorthand. It renders a `div` element.
Flex is `CBox` with `display: flex` and comes with helpful style shorthand. It renders a `div` element.

Copy link
Collaborator

@carwack carwack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small changes and we are good to go!

components/content/examples/flex/SignUpFlex.vue Outdated Show resolved Hide resolved
components/content/examples/flex/SignUpFlex.vue Outdated Show resolved Hide resolved
content/4.components/flex.md Outdated Show resolved Hide resolved

# Flex

Flex is `Box` with `display: flex` and comes with helpful style shorthand. It renders a `div` element.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Flex is `Box` with `display: flex` and comes with helpful style shorthand. It renders a `div` element.
Flex is `CBox` with `display: flex` and comes with helpful style shorthand. It renders a `div` element.

Copy link
Collaborator

@carwack carwack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding this! 🚀

@carwack carwack merged commit e2d0192 into chakra-ui:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants