Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add github repository link #35

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

D-Lite
Copy link
Contributor

@D-Lite D-Lite commented May 30, 2023

edit

Add github repository link to the page footer

@vercel
Copy link

vercel bot commented May 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
vue-docs-next ✅ Ready (Inspect) Visit Preview Jun 26, 2023 8:55am

Copy link
Contributor

@Shyrro Shyrro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @D-Lite ,

Thanks for opening this PR!

If you look at the generated staging, all the Edit this page on Github links seem to be broken for some reason.

Also, the link shouldn't just be the repository, it should link to the right .md file. You can do this based on the url as we use file path routing for our documentation.

Let me know if you have anymore questions.

@D-Lite
Copy link
Contributor Author

D-Lite commented Jun 26, 2023

@Shyrro nuxt/nuxt#21340 This issue on the nuxt repository explained the error I was facing earlier. I had a workaround with computed properties as suggested on the issue.

Everything works fine now

@D-Lite
Copy link
Contributor Author

D-Lite commented Aug 6, 2023

@Shyrro @carwack , you might want to review this pr. It cuts across the entire application and a reproducible example exists already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants