fix: false positive in array of object value (#151)

chakra-ui · Sep 25, 2024 · fb2c97e · fb2c97e
1 parent 2214da3
commit fb2c97e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/plugin/src/rules/no-dynamic-styling.ts b/plugin/src/rules/no-dynamic-styling.ts
@@ -79,9 +79,6 @@ const rule: Rule = createRule({
 
         // Don't warn for objects. Those are conditions
         if (isObjectExpression(node.value)) return
-        if (isArrayExpression(node.value)) {
-          return checkElements(node.value, context)
-        }
 
         if (!isPandaAttribute(node, context)) return
 

diff --git a/plugin/tests/no-dynamic-styling.test.ts b/plugin/tests/no-dynamic-styling.test.ts
@@ -35,6 +35,12 @@ function App(){
   return <styled.div color='red.100' />;
 }`,
   },
+  {
+    code: javascript`
+const foo = 'foo'
+const nonStyles = {bar: [foo]}
+`,
+  },
 ]
 
 const invalids = [