Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

fix(components): Add missing as prop on some layout components #329

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

carwack
Copy link
Collaborator

@carwack carwack commented Oct 7, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes
    /start features)

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Some of the Layout components were missing the as prop in their template

What is the new behavior?

  • Added as prop to template

Does this introduce a breaking change?

  • Yes
  • No

Other information

Question: Does all the Layout components I added the missing as prop to need it? I saw that the prop was added but not added in the template.

@carwack carwack added type: bug 🐛 Something isn't working status: ready for review 👍🏽 Pull request is ready for review ☄️ core team This issue/pull request has been opened by a Vue core team member labels Oct 7, 2023
@carwack carwack self-assigned this Oct 7, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2023

🦋 Changeset detected

Latest commit: 8c7d7ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@chakra-ui/vue-layout Patch
@chakra-ui/c-avatar Patch
@chakra-ui/c-menu Patch
@chakra-ui/vue-next Patch
@chakra-ui/c-select Patch
@chakra-ui/nuxt-next Patch
@chakra-ui/vue-auto-import Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
chakra-ui-vue-next-playground ✅ Ready (Inspect) Visit Preview Oct 9, 2023 7:23pm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
☄️ core team This issue/pull request has been opened by a Vue core team member status: ready for review 👍🏽 Pull request is ready for review type: bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant