Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration file overhaul #288

Closed
wants to merge 28 commits into from
Closed

Conversation

ceyhunsen
Copy link
Member

Description

This PR overhauls configuration file:

  • Adds sections for grouping

Linked Issues

Testing

New sections are tested in unit tests.

Docs

New sections has comments.

@ceyhunsen ceyhunsen self-assigned this Sep 10, 2024
@ceyhunsen ceyhunsen marked this pull request as ready for review September 10, 2024 09:48
@ceyhunsen ceyhunsen marked this pull request as draft September 10, 2024 11:14
@ceyhunsen ceyhunsen changed the base branch from main to dev September 13, 2024 11:34
ekrembal and others added 8 commits September 13, 2024 15:32
* Add fee checking

* Add error type

* nits

* Change config + update fee constants

* Fix CI config error + Add operator config check

* nits

* Small fix

* nits

* Add withdrawal utxo checks for citrea

* fmt

* Add citrea checks insturctions for withdrawal_proved_on_citrea

* WIP withdrawal checks

* Fix indexing

* Return error on not enough fee for withdrawal

* Add operator_wallet_addresses

* Fix actions

* typo

* nits

---------

Co-authored-by: ozankaymak <[email protected]>
Co-authored-by: ozankaymak <[email protected]>
* actor: Add tracing::instrument logs.

* aggregator: Add tracing::instrument.

* extended_rpc: Add tracing::instrument to everywhere.

* musig2: Add tracing::instrument.

* operator: Add tracing::instrument.

* script_builder: Add tracing::instrument.

* server: Add tracing::instrument.

* tx_builder: Add tracing::instrument.

* user: Add tracing::instrument.

* verifier: Add tracing::instrument.

* servers: Fix clippy error.

* database: Add tracing::instrument.

* actor: Remove unnecessary logs.
* config: Add comments to test config.

* tests: Update some of the filed comments.
* workflow: Add initial line coverage.

* workflow: Fix code coverage.

* workflow: Update code checks.

* workflow: Renamings.

* workflow: Code coverage to code_checks.

* gitignore: Add lcov.info.

* workflow: Save lines and function coverage percantage.

* scripts: Add line coverage check.

* workflow: Use new script to check line coverage.

* workflow: Use CARGOFLAGS.

* Revert "workflow: Use CARGOFLAGS."

This reverts commit bd9da21.
* Reverse txs_to_be_sent for kickoff generators

* WIP additional testing with small fixes + db problem

* Fix test + add asserts

---------

Co-authored-by: Ekrem BAL <[email protected]>
ceyhunsen and others added 5 commits September 13, 2024 15:34
* readme: Update testing methods.

* readme: Add config file preparation.

* readme: Add server starter.

* readme: Remove included item.

* readme: Add build than run.

* readme: its.

* readme: Grammer (by ChatGPT).
* cargo: Update build flags.

* workflow: Release mode checks only in ready for review.

* workflow: Add more ready for review checks.

* workflow: Add pull_request for on.

* Revert "workflow: Add pull_request for on."

This reverts commit 85694bd.

* workflow: Remove if readies.
@ceyhunsen
Copy link
Member Author

This is continued in #306

@ceyhunsen ceyhunsen closed this Sep 13, 2024
@ceyhunsen ceyhunsen deleted the ceyhun/config_file_structure branch September 13, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration File Documentation And Structure Updates
3 participants