Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update various GitHub Actions for security updates #28

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

chabala
Copy link
Owner

@chabala chabala commented Oct 13, 2024

@dependabot opened issue #27 on Sept 3rd to update https://github.com/actions/download-artifact from v3 to v4.1.7.

But curiously, it didn't mention updating actions/upload-artifact@v3, which is also based on actions/artifact.

It also didn't mention the reason for the update: GHSA-cxww-7g56-2vh6

actions/[email protected] contains actions/[email protected] which resolves the path traversal issue.

It also fixes a more serious issue, leaking tokens in hidden files in artifacts:

Other reasons for moving to v4:

@chabala chabala self-assigned this Oct 13, 2024
@chabala chabala force-pushed the github-actions-update branch from 303745c to aab23e3 Compare October 13, 2024 20:12
Copy link

sonarcloud bot commented Oct 13, 2024

@coveralls
Copy link

Coverage Status

coverage: 67.223%. remained the same
when pulling aab23e3 on github-actions-update
into 3e74c25 on master.

@chabala
Copy link
Owner Author

chabala commented Oct 13, 2024

SonarQube & Coveralls both complained the git tree was missing from the downloaded actions artifact: https://github.com/chabala/brick-control-lab/actions/runs/11317259280

Rather than set include-hidden-files: true and try to ensure .git is added, but not other hidden files that I don't even know about, it seems simpler to do another clean checkout in the SonarQube/Coveralls jobs and extract the actions artifact on top.

@chabala chabala merged commit b94a464 into master Oct 13, 2024
9 checks passed
@chabala chabala deleted the github-actions-update branch October 13, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants