ENT-9980: Properly handle promise locking with edit line #5815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsewi
force-pushed
the
render
branch
4 times, most recently
from
5a945a1 to
dd79a5a
Compare
|
Thank you for submitting a pull request! Maybe @craigcomstock can review this? |
larsewi
force-pushed
the
render
branch
2 times, most recently
from
a88a0df to
368096e
Compare
This file requires the definition of the enum `PromiseResult`. Signed-off-by: Lars Erik Wik <[email protected]>
This file requires the definition of the enum `PromiseResult`. Signed-off-by: Lars Erik Wik <[email protected]>
Signed-off-by: Lars Erik Wik <[email protected]>
Fixed bug causing rendered files can result in erroneously empty files as a result of promise locking. Ticket: ENT-9980 Changelog: Commit Signed-off-by: Lars Erik Wik <[email protected]>
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12205/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12205/ |
craigcomstock
approved these changes
Jun 10, 2025
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/12221/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12221/ |
This was referenced Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back-ported to: