Adding check for log file/log directory existence #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding check for log file/log directory existence - Had to manually create the location when installed on OSX
ceuk
requested changes
Dec 28, 2022
| with open('sample.csv', 'w') as creating_new_log_file: | ||
| pass | ||
|
|
||
| logging.basicConfig(filename, filemode='w', |
There was a problem hiding this comment.
logging.basicConfig doesn't take any position args. If you look at the original code (or just check the function signature) you'll see it expects filename as a keyword arg. I'd suggest running your code at least once just to sanity check this kind of thing
|
|
||
| # if log file doesn't exist | ||
| if not os.path.isfile(filename): | ||
| with open('sample.csv', 'w') as creating_new_log_file: |
| try: | ||
| os.makedirs(os.path.dirname(filename)) | ||
| except OSError as exc: # prevent race condition | ||
| if exc.errno != errno.EEXIST: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding check for log file/log directory existence - Had to manually create the location when installed on OSX