Merge pull request #14 from Ram-Amoncar/fixed-solution

fixed solution for christmas-tree
cesalberca · Jul 10, 2024 · 1e8cdfa · 1e8cdfa
2 parents 11bad72 + 5caba6f
commit 1e8cdfa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/christmas-tree/solutions/christmas-tree.spec.ts b/src/christmas-tree/solutions/christmas-tree.spec.ts
@@ -1,7 +1,7 @@
 import { describe, it, expect } from 'vitest'
 import { ChristmasTree } from './christmas-tree'
 
-describe.skip('ChristmasTree', () => {
+describe('ChristmasTree', () => {
   it('should render a tree with 3 rows', () => {
     const christmasTree = new ChristmasTree()
 

diff --git a/src/christmas-tree/solutions/christmas-tree.ts b/src/christmas-tree/solutions/christmas-tree.ts
@@ -16,7 +16,7 @@ export class ChristmasTree {
     const finalTree = treeArr
       .map((x, i) => {
         const paddedSpaces = Math.floor(maxStarsPerRow / 2) + i * -1
-        return x.padStart(paddedSpaces).padEnd(paddedSpaces)
+        return x.padStart(maxStarsPerRow - paddedSpaces)
       })
       .join('\n')
 
@@ -30,6 +30,7 @@ export class ChristmasTree {
       const isHalf = i === half
       if (isHalf) {
         lastRow += '|'
+        break
       } else {
         lastRow += ' '
       }