Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StackOverflowError when creating infinite recursion #1

Open
cerus opened this issue Jul 29, 2020 · 8 comments
Open

StackOverflowError when creating infinite recursion #1

cerus opened this issue Jul 29, 2020 · 8 comments
Labels
bug Something isn't working Hacktoberfest up for grabs A contribution fixing this issue is very much wanted

Comments

@cerus
Copy link
Owner

cerus commented Jul 29, 2020

How to reproduce:

  1. Create infinite recursion with gates
  2. Hook an output into it
  3. See console
@cerus cerus added bug Something isn't working up for grabs A contribution fixing this issue is very much wanted labels Jul 29, 2020
@cerus
Copy link
Owner Author

cerus commented Jul 30, 2020

After thinking about this issue for a while I might have come up with a solution:

  1. Add the method Set<Node> getLastNodes to the ConnectorHolder interface
  2. Implement the method in a way that it returns the nodes at the end of the connections
  3. When connecting a node (A) to another node (B) check if the last nodes of A contain B; If so, abort connecting

This is just an idea. I'll try to fix this when I get home from work as long as no one else has claimed this issue. It's still up for grabs!

@cerus
Copy link
Owner Author

cerus commented Jul 30, 2020

Turns out my idea didn't really work

@kaggrwal
Copy link

kaggrwal commented Oct 4, 2020

I would like to see it, can you assign it to me and also, please provide the steps to run the program.

@cerus
Copy link
Owner Author

cerus commented Oct 4, 2020

Sure, I'll assign this issue to you. Every modern IDE should be able to run the main class directly but these are the manual steps:

  1. Clone this repository git clone https://github.com/RealCerus/logic-builder.git
  2. Change directory cd logic-builder
  3. Build the project with Maven mvn package
  4. Run the jar file java -jar target/logic-builder-1.0.0.jar

@cerus
Copy link
Owner Author

cerus commented Oct 7, 2020

@kaggrwal Any progress so far?

@kaggrwal
Copy link

kaggrwal commented Oct 8, 2020

@RealCerus Hi, I didn't get the time, i'll try it soon and let you know about the progress.

@kaggrwal
Copy link

kaggrwal commented Oct 9, 2020

@RealCerus Can we discuss it over IRC/chat ?

@cerus
Copy link
Owner Author

cerus commented Oct 9, 2020

You can add me on Discord Cerus#5149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Hacktoberfest up for grabs A contribution fixing this issue is very much wanted
Projects
None yet
Development

No branches or pull requests

2 participants