Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Json exporter & importer #3

Open
cerus opened this issue Jul 29, 2020 · 5 comments
Open

Add Json exporter & importer #3

cerus opened this issue Jul 29, 2020 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest up for grabs A contribution fixing this issue is very much wanted

Comments

@cerus
Copy link
Owner

cerus commented Jul 29, 2020

Add way for users to export their logic creation into Json. They should also be able to import exported Json creations.
@cerus cerus added enhancement New feature or request up for grabs A contribution fixing this issue is very much wanted labels Jul 29, 2020
@cerus cerus mentioned this issue Jul 29, 2020
Open
@cerus cerus added the good first issue Good for newcomers label Jul 29, 2020
@Paul2708
Copy link
Contributor

Paul2708 commented Oct 7, 2020

Hey, I would like to work on this one. :)

I would suggest two simple buttons Save and Load. Both open a file system dialog to either create or choose a file.
What are your thoughts on this?

@cerus
Copy link
Owner Author

cerus commented Oct 7, 2020 •
edited
Loading

Sure, sounds good! The implementation is completely up to you. But keep in mind that it is currently possible to create an infinite loop with components. (See #1)

@cerus cerus assigned cerus and Paul2708 and unassigned cerus Oct 7, 2020
@cerus
Copy link
Owner Author

cerus commented Sep 9, 2021

Just stumbled upon this again after a year, did this get implemented or did we completely forget about this thing? @Paul2708

@Paul2708
Copy link
Contributor

Paul2708 commented Sep 9, 2021

I tried to implement this but I got stuck if I remember correctly.
The problem was related to storing the superclass as well.

I pushed my recent changes to https://github.com/Paul2708/logic-builder/tree/exporter but I do not have any time left atm. 😞

@Paul2708 Paul2708 removed their assignment Sep 9, 2021
@cerus
Copy link
Owner Author

cerus commented Sep 9, 2021

Alright, no problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest up for grabs A contribution fixing this issue is very much wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Paul2708 @cerus