Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump all dependencies #6821

Merged
merged 5 commits into from May 21, 2024
Merged

Bump all dependencies #6821

merged 5 commits into from May 21, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Mar 7, 2024 •
edited

In kubernetes/kubernetes#123529, all the generators were drastically updated. This breaks our hack/k8s-codegen.sh script. This PR upgrades the generators and updates the script to use the new flags.

Kind

/kind cleanup

Release Note

NONE

@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/acme Indicates a PR directly modifies the ACME Issuer code labels Mar 7, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from inteon. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the area/testing Issues relating to testing label Mar 7, 2024
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2024
@jetstack-bot jetstack-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 11, 2024
@jetstack-bot
Copy link
Contributor

@inteon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-master-e2e-v1-28-upgrade 8631350 link true /test pull-cert-manager-master-e2e-v1-28-upgrade
pull-cert-manager-master-e2e-v1-28 8631350 link true /test pull-cert-manager-master-e2e-v1-28
pull-cert-manager-master-make-test 8631350 link true /test pull-cert-manager-master-make-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2024
@jetstack-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cert-manager-prow cert-manager-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2024
@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2024
@cert-manager-prow cert-manager-prow bot added area/deploy Indicates a PR modifies deployment configuration and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 17, 2024
@inteon inteon force-pushed the bump_deps branch 2 times, most recently from 66bf5aa to 7282141 Compare May 17, 2024 09:16
@inteon inteon added this to the 1.15 milestone May 17, 2024
@inteon
upgrade dependencies
9483f5d 
Signed-off-by: Tim Ramlot <[email protected]>
@inteon
re-generate crds
515559a 
Signed-off-by: Tim Ramlot <[email protected]>
@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented May 17, 2024 •
edited

@inteon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cert-manager-master-e2e-v1-28-upgrade 558b7c4 link true /test pull-cert-manager-master-e2e-v1-28-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@SgtCoDFish
Copy link
Member

/override pull-cert-manager-master-e2e-v1-28-upgrade

@cert-manager-prow
Copy link
Contributor

@SgtCoDFish: Overrode contexts on behalf of SgtCoDFish: pull-cert-manager-master-e2e-v1-28-upgrade

In response to this:

/override pull-cert-manager-master-e2e-v1-28-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SgtCoDFish
Copy link
Member

/test pull-cert-manager-master-e2e-v1-28

SgtCoDFish
SgtCoDFish requested changes May 20, 2024
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, it doesn't look like it was much fun to deal with these kinds of breaking upstream changes 😦 Just a few little things - what do you think?

cmd/acmesolver/go.mod Show resolved Hide resolved
deploy/crds/crd-issuers.yaml
TODO: Add other useful fields. apiVersion, kind, uid?
More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
TODO: Drop `kubebuilder:default` when controller-gen doesn't need it https://github.com/kubernetes-sigs/kubebuilder/issues/3896.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment: Not anything that needs to change in this PR, but it's annoying to see "TODOs" in our CRD docs like this - shame that the generator isn't stripping them out

hack/k8s-codegen.sh Outdated Show resolved Hide resolved
make/ci.mk Show resolved Hide resolved
@inteon inteon requested a review from SgtCoDFish May 21, 2024 08:39
@inteon
Copy link
Member Author

inteon commented May 21, 2024

/override pull-cert-manager-master-e2e-v1-28-upgrade

@cert-manager-prow
Copy link
Contributor

@inteon: Overrode contexts on behalf of inteon: pull-cert-manager-master-e2e-v1-28-upgrade

In response to this:

/override pull-cert-manager-master-e2e-v1-28-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@inteon
Copy link
Member Author

inteon commented May 21, 2024

/test pull-cert-manager-master-e2e-v1-28

SgtCoDFish
SgtCoDFish approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Cheers, looks good!

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@cert-manager-prow cert-manager-prow bot merged commit a26a0a8 into cert-manager:master May 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme Indicates a PR directly modifies the ACME Issuer code area/deploy Indicates a PR modifies deployment configuration area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
1.15
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@inteon @jetstack-bot @SgtCoDFish