Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect translation key for parameter_not_allowed.detail #1469

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pozzer
Copy link

@pozzer pozzer commented Feb 28, 2025

Closes #1468.

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (I ran the full test suite locally to avoid unnecessary failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fail without the change.

Test Plan:

The issue occurs because the translation key being used in the code is incorrect.
The code currently looks for parameters_not_allowed.detail (plural), but the correct key in the translation files is parameter_not_allowed.detail (singular).

  • Added a test to verify that the correct key (parameter_not_allowed.detail) is used.
  • Without the fix, the test fails because the translation isn't found, falling back to the default English message.
  • With the fix, the test correctly retrieves the translation.

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix incorrect translation key for parameter_not_allowed.detail
1 participant