Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace ethers with viem #1037

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: replace ethers with viem #1037

wants to merge 1 commit into from

Conversation

dbcfd
Copy link

@dbcfd dbcfd commented May 17, 2023

No description provided.

@linear
Copy link

linear bot commented May 17, 2023

CDB-2128 Nonce errors in Clay AND QA CAS

Coordinator: dbrowning

Investigator: dbrowning

Clay CAS:

https://us-east-2.console.aws.amazon.com/cloudwatch/home?region=us-east-2#logsV2:log-groups/log-group/$252Fecs$252Fceramic-tnet-cas/log-events/cas_anchor$252Fcas_anchor$252F7dd464817de349c5aab085d2ca1fa13c

2022-12-12T04:50:36.417-05:00	[2022-12-12T09:50:36.417Z] IMPORTANT: 'Sending transaction to Ethereum gnosischain network...'
2022-12-12T04:50:36.549-05:00	[2022-12-12T09:50:36.549Z] ERROR: Error: processing response error (body="{\"jsonrpc\":\"2.0\",\"error\":{\"code\":-32010,\"message\":\"OldNonce, Current nonce: 14598, nonce of rejected tx: 14597\"},\"id\":75}", error={"code":-32010}, requestBody="{\"method\":\"eth_sendRawTransaction\",\"params\":[\"0x02f89164823905846c2eb3c0846c2eb3ce825458941c124c86f7fc22e67974337e889a513b16a5703f80a50f0171122074908374996e263646907a2aa7d9bb264276d638ba0d8ce4d392e5b2aa1da87ac080a0fe8ad67d823ddc02de612df8e810ddabfec8bb2271ed29751783a573724b29eea05827cd0bf3d5c4f612270678a9c6e0a36329bc0948c914d129289837ed9c3bd2\"],\"id\":75,\"jsonrpc\":\"2.0\"}", requestMethod="POST", url="https://quiet-cool-firefly.xdai.discover.quiknode.pro/d524192eabefb55f8a9911ff4dccce042f650ae0/", code=SERVER_ERROR, version=web/5.7.1)
2022-12-12T04:50:36.549-05:00	at Logger.makeError (/cas/node_modules/ethersproject/logger/lib/index.js:238:21)
2022-12-12T04:50:36.549-05:00	at Logger.throwError (/cas/node_modules/ethersproject/logger/lib/index.js:247:20)
2022-12-12T04:50:36.549-05:00	at /cas/node_modules/ethersproject/web/lib/index.js:313:32
2022-12-12T04:50:36.549-05:00	at step (/cas/node_modules/ethersproject/web/lib/index.js:33:23)
2022-12-12T04:50:36.549-05:00	at Object.next (/cas/node_modules/ethersproject/web/lib/index.js:14:53)
2022-12-12T04:50:36.549-05:00	at fulfilled (/cas/node_modules/ethersproject/web/lib/index.js:5:58)
2022-12-12T04:50:36.549-05:00	at runMicrotasks (<anonymous>)
2022-12-12T04:50:36.549-05:00	at processTicksAndRejections (node:internal/process/task_queues:96:5) {
2022-12-12T04:50:36.549-05:00	reason: 'processing response error',
2022-12-12T04:50:36.549-05:00	code: 'SERVER_ERROR',
2022-12-12T04:50:36.549-05:00	body: '{"jsonrpc":"2.0","error":{"code":-32010,"message":"OldNonce, Current nonce: 14598, nonce of rejected tx: 14597"},"id":75}',
2022-12-12T04:50:36.549-05:00	error: Error: OldNonce, Current nonce: 14598, nonce of rejected tx: 14597
2022-12-12T04:50:36.549-05:00	at getResult (/cas/node_modules/ethersproject/providers/lib/json-rpc-provider.js:191:21)
2022-12-12T04:50:36.549-05:00	at processJsonFunc (/cas/node_modules/ethersproject/web/lib/index.js:356:22)
2022-12-12T04:50:36.549-05:00	at /cas/node_modules/ethersproject/web/lib/index.js:288:46
2022-12-12T04:50:36.549-05:00	at step (/cas/node_modules/ethersproject/web/lib/index.js:33:23)
2022-12-12T04:50:36.549-05:00	at Object.next (/cas/node_modules/ethersproject/web/lib/index.js:14:53)
2022-12-12T04:50:36.549-05:00	at fulfilled (/cas/node_modules/ethersproject/web/lib/index.js:5:58)
2022-12-12T04:50:36.549-05:00	at runMicrotasks (<anonymous>)
2022-12-12T04:50:36.549-05:00	at processTicksAndRejections (node:internal/process/task_queues:96:5) {
2022-12-12T04:50:36.549-05:00	code: -32010,
2022-12-12T04:50:36.549-05:00	data: undefined
2022-12-12T04:50:36.549-05:00	},
2022-12-12T04:50:36.549-05:00	requestBody: '{"method":"eth_sendRawTransaction","params":["0x02f89164823905846c2eb3c0846c2eb3ce825458941c124c86f7fc22e67974337e889a513b16a5703f80a50f0171122074908374996e263646907a2aa7d9bb264276d638ba0d8ce4d392e5b2aa1da87ac080a0fe8ad67d823ddc02de612df8e810ddabfec8bb2271ed29751783a573724b29eea05827cd0bf3d5c4f612270678a9c6e0a36329bc0948c914d129289837ed9c3bd2"],"id":75,"jsonrpc":"2.0"}',
2022-12-12T04:50:36.549-05:00	requestMethod: 'POST',
2022-12-12T04:50:36.549-05:00	url: 'https://quiet-cool-firefly.xdai.discover.quiknode.pro/d524192eabefb55f8a9911ff4dccce042f650ae0/',
2022-12-12T04:50:36.549-05:00	transaction: {
2022-12-12T04:50:36.549-05:00	type: 2,
2022-12-12T04:50:36.549-05:00	chainId: 100,
2022-12-12T04:50:36.549-05:00	nonce: 14597,
2022-12-12T04:50:36.549-05:00	maxPriorityFeePerGas: BigNumber { _hex: '0x6c2eb3c0', _isBigNumber: true },
2022-12-12T04:50:36.549-05:00	maxFeePerGas: BigNumber { _hex: '0x6c2eb3ce', _isBigNumber: true },
2022-12-12T04:50:36.549-05:00	gasPrice: null,
2022-12-12T04:50:36.549-05:00	gasLimit: BigNumber { _hex: '0x5458', _isBigNumber: true },
2022-12-12T04:50:36.549-05:00	to: '0x1C124c86f7fc22e67974337E889a513b16a5703f',
2022-12-12T04:50:36.549-05:00	value: BigNumber { _hex: '0x00', _isBigNumber: true },
2022-12-12T04:50:36.549-05:00	data: '0x0f0171122074908374996e263646907a2aa7d9bb264276d638ba0d8ce4d392e5b2aa1da87a',
2022-12-12T04:50:36.549-05:00	accessList: [],
2022-12-12T04:50:36.549-05:00	hash: '0xf1e0d645f0948f9076491c9df797b1953e8fecceab23ff8520969c7736338d46',
2022-12-12T04:50:36.549-05:00	v: 0,
2022-12-12T04:50:36.549-05:00	r: '0xfe8ad67d823ddc02de612df8e810ddabfec8bb2271ed29751783a573724b29ee',
2022-12-12T04:50:36.549-05:00	s: '0x5827cd0bf3d5c4f612270678a9c6e0a36329bc0948c914d129289837ed9c3bd2',
2022-12-12T04:50:36.549-05:00	from: '0x1C124c86f7fc22e67974337E889a513b16a5703f',
2022-12-12T04:50:36.549-05:00	confirmations: 0
2022-12-12T04:50:36.549-05:00	},
2022-12-12T04:50:36.549-05:00	transactionHash: '0xf1e0d645f0948f9076491c9df797b1953e8fecceab23ff8520969c7736338d46'
2022-12-12T04:50:36.549-05:00	}
2022-12-12T04:50:36.549-05:00	[2022-12-12T09:50:36.549Z] WARNING: 'Failed to send transaction; 0 retries remain'

QA CAS:

https://us-east-2.console.aws.amazon.com/cloudwatch/home?region=us-east-2#logsV2:log-groups/log-group/$252Fecs$252Fceramic-qa-cas/log-events/cas_anchor$252Fcas_anchor$252Fd8b1a8e4c9d34198bd7e72f4f2686700

2022-12-11T00:51:41.522-05:00	[2022-12-11T05:51:41.522Z] IMPORTANT: 'Sending transaction to Ethereum goerli network...'
2022-12-11T00:51:41.717-05:00	[2022-12-11T05:51:41.717Z] ERROR: Error: nonce has already been used [ See: https://links.ethers.org/v5-errors-NONCE_EXPIRED ] (error={"reason":"processing response error","code":"SERVER_ERROR","body":"{\"jsonrpc\":\"2.0\",\"id\":65,\"error\":{\"code\":-32000,\"message\":\"nonce too low\"}}","error":{"code":-32000},"requestBody":"{\"method\":\"eth_sendRawTransaction\",\"params\":[\"0x02f89105821b6f846259008084625ce33e8254589441ee0c359d95970a83229d8e9801cc267239021780a50f01711220337eb7b11ff378b7f64e8d1a16bed17ffc2e0d4a69e0245a973396fa2a8f4be0c080a0415b4dfd2157f507aa3bfc0e832d1b6960afec5a5c1fe4cfbc63072d36ab49d6a072447e5a3228553dfa145982f6f6d527542ea8f742c8db6976d7dbf847024e59\"],\"id\":65,\"jsonrpc\":\"2.0\"}","requestMethod":"POST","url":"https://goerli.infura.io/v3/b6685df41e1647c4be0046dfa62a020b"}, method="sendTransaction", transaction="0x02f89105821b6f846259008084625ce33e8254589441ee0c359d95970a83229d8e9801cc267239021780a50f01711220337eb7b11ff378b7f64e8d1a16bed17ffc2e0d4a69e0245a973396fa2a8f4be0c080a0415b4dfd2157f507aa3bfc0e832d1b6960afec5a5c1fe4cfbc63072d36ab49d6a072447e5a3228553dfa145982f6f6d527542ea8f742c8db6976d7dbf847024e59", code=NONCE_EXPIRED, version=providers/5.7.2)
2022-12-11T00:51:41.717-05:00	at Logger.makeError (/cas/node_modules/ethersproject/logger/lib/index.js:238:21)
2022-12-11T00:51:41.717-05:00	at Logger.throwError (/cas/node_modules/ethersproject/logger/lib/index.js:247:20)
2022-12-11T00:51:41.717-05:00	at checkError (/cas/node_modules/ethersproject/providers/lib/json-rpc-provider.js:152:16)
2022-12-11T00:51:41.717-05:00	at JsonRpcProvider.<anonymous> (/cas/node_modules/ethersproject/providers/lib/json-rpc-provider.js:751:47)
2022-12-11T00:51:41.717-05:00	at step (/cas/node_modules/ethersproject/providers/lib/json-rpc-provider.js:48:23)
2022-12-11T00:51:41.717-05:00	at Object.throw (/cas/node_modules/ethersproject/providers/lib/json-rpc-provider.js:29:53)
2022-12-11T00:51:41.717-05:00	at rejected (/cas/node_modules/ethersproject/providers/lib/json-rpc-provider.js:21:65)
2022-12-11T00:51:41.717-05:00	at processTicksAndRejections (node:internal/process/task_queues:96:5) {
2022-12-11T00:51:41.717-05:00	reason: 'nonce has already been used',
2022-12-11T00:51:41.717-05:00	code: 'NONCE_EXPIRED',
2022-12-11T00:51:41.717-05:00	error: Error: processing response error (body="{\"jsonrpc\":\"2.0\",\"id\":65,\"error\":{\"code\":-32000,\"message\":\"nonce too low\"}}", error={"code":-32000}, requestBody="{\"method\":\"eth_sendRawTransaction\",\"params\":[\"0x02f89105821b6f846259008084625ce33e8254589441ee0c359d95970a83229d8e9801cc267239021780a50f01711220337eb7b11ff378b7f64e8d1a16bed17ffc2e0d4a69e0245a973396fa2a8f4be0c080a0415b4dfd2157f507aa3bfc0e832d1b6960afec5a5c1fe4cfbc63072d36ab49d6a072447e5a3228553dfa145982f6f6d527542ea8f742c8db6976d7dbf847024e59\"],\"id\":65,\"jsonrpc\":\"2.0\"}", requestMethod="POST", url="https://goerli.infura.io/v3/b6685df41e1647c4be0046dfa62a020b", code=SERVER_ERROR, version=web/5.7.1)
2022-12-11T00:51:41.717-05:00	at Logger.makeError (/cas/node_modules/ethersproject/logger/lib/index.js:238:21)
2022-12-11T00:51:41.717-05:00	at Logger.throwError (/cas/node_modules/ethersproject/logger/lib/index.js:247:20)
2022-12-11T00:51:41.717-05:00	at /cas/node_modules/ethersproject/web/lib/index.js:313:32
2022-12-11T00:51:41.717-05:00	at step (/cas/node_modules/ethersproject/web/lib/index.js:33:23)
2022-12-11T00:51:41.717-05:00	at Object.next (/cas/node_modules/ethersproject/web/lib/index.js:14:53)
2022-12-11T00:51:41.717-05:00	at fulfilled (/cas/node_modules/ethersproject/web/lib/index.js:5:58)
2022-12-11T00:51:41.717-05:00	at processTicksAndRejections (node:internal/process/task_queues:96:5) {
2022-12-11T00:51:41.717-05:00	reason: 'processing response error',
2022-12-11T00:51:41.717-05:00	code: 'SERVER_ERROR',
2022-12-11T00:51:41.717-05:00	body: '{"jsonrpc":"2.0","id":65,"error":{"code":-32000,"message":"nonce too low"}}',
2022-12-11T00:51:41.717-05:00	error: Error: nonce too low
2022-12-11T00:51:41.717-05:00	at getResult (/cas/node_modules/ethersproject/providers/lib/json-rpc-provider.js:191:21)
2022-12-11T00:51:41.717-05:00	at processJsonFunc (/cas/node_modules/ethersproject/web/lib/index.js:356:22)
2022-12-11T00:51:41.717-05:00	at /cas/node_modules/ethersproject/web/lib/index.js:288:46
2022-12-11T00:51:41.717-05:00	at step (/cas/node_modules/ethersproject/web/lib/index.js:33:23)
2022-12-11T00:51:41.717-05:00	at Object.next (/cas/node_modules/ethersproject/web/lib/index.js:14:53)
2022-12-11T00:51:41.717-05:00	at fulfilled (/cas/node_modules/ethersproject/web/lib/index.js:5:58)
2022-12-11T00:51:41.717-05:00	at processTicksAndRejections (node:internal/process/task_queues:96:5) {
2022-12-11T00:51:41.717-05:00	code: -32000,
2022-12-11T00:51:41.717-05:00	data: undefined
2022-12-11T00:51:41.717-05:00	},
2022-12-11T00:51:41.717-05:00	requestBody: '{"method":"eth_sendRawTransaction","params":["0x02f89105821b6f846259008084625ce33e8254589441ee0c359d95970a83229d8e9801cc267239021780a50f01711220337eb7b11ff378b7f64e8d1a16bed17ffc2e0d4a69e0245a973396fa2a8f4be0c080a0415b4dfd2157f507aa3bfc0e832d1b6960afec5a5c1fe4cfbc63072d36ab49d6a072447e5a3228553dfa145982f6f6d527542ea8f742c8db6976d7dbf847024e59"],"id":65,"jsonrpc":"2.0"}',
2022-12-11T00:51:41.717-05:00	requestMethod: 'POST',
2022-12-11T00:51:41.717-05:00	url: 'https://goerli.infura.io/v3/b6685df41e1647c4be0046dfa62a020b'
2022-12-11T00:51:41.717-05:00	},
2022-12-11T00:51:41.717-05:00	method: 'sendTransaction',
2022-12-11T00:51:41.717-05:00	transaction: {
2022-12-11T00:51:41.717-05:00	type: 2,
2022-12-11T00:51:41.717-05:00	chainId: 5,
2022-12-11T00:51:41.717-05:00	nonce: 7023,
2022-12-11T00:51:41.717-05:00	maxPriorityFeePerGas: BigNumber { _hex: '0x62590080', _isBigNumber: true },
2022-12-11T00:51:41.717-05:00	maxFeePerGas: BigNumber { _hex: '0x625ce33e', _isBigNumber: true },
2022-12-11T00:51:41.717-05:00	gasPrice: null,
2022-12-11T00:51:41.717-05:00	gasLimit: BigNumber { _hex: '0x5458', _isBigNumber: true },
2022-12-11T00:51:41.717-05:00	to: '0x41Ee0C359D95970A83229D8e9801cc2672390217',
2022-12-11T00:51:41.717-05:00	value: BigNumber { _hex: '0x00', _isBigNumber: true },
2022-12-11T00:51:41.717-05:00	data: '0x0f01711220337eb7b11ff378b7f64e8d1a16bed17ffc2e0d4a69e0245a973396fa2a8f4be0',
2022-12-11T00:51:41.717-05:00	accessList: [],
2022-12-11T00:51:41.717-05:00	hash: '0xf98597323e510f45e45745da0c060adf57de407d16051571272ee3cf747877e1',
2022-12-11T00:51:41.717-05:00	v: 0,
2022-12-11T00:51:41.717-05:00	r: '0x415b4dfd2157f507aa3bfc0e832d1b6960afec5a5c1fe4cfbc63072d36ab49d6',
2022-12-11T00:51:41.717-05:00	s: '0x72447e5a3228553dfa145982f6f6d527542ea8f742c8db6976d7dbf847024e59',
2022-12-11T00:51:41.717-05:00	from: '0x41Ee0C359D95970A83229D8e9801cc2672390217',
2022-12-11T00:51:41.717-05:00	confirmations: 0
2022-12-11T00:51:41.717-05:00	},
2022-12-11T00:51:41.717-05:00	transactionHash: '0xf98597323e510f45e45745da0c060adf57de407d16051571272ee3cf747877e1'
2022-12-11T00:51:41.717-05:00	}
2022-12-11T00:51:41.718-05:00	[Sun, 11 Dec 2022 05:51:41 GMT] service=ethereum type=nonceExpired nonce=7023
2022-12-11T00:51:41.720-05:00	[2022-12-11T05:51:41.720Z] WARNING: 'Updating PROCESSING requests to PENDING so they are retried in the next batch because an error occured while creating the anchors: Error: nonce has already been used [ See: https://links.ethers.org/v5-errors-NONCE_EXPIRED ] (error={"reason":"processing response error","code":"SERVER_ERROR","body":"{\\"jsonrpc\\":\\"2.0\\",\\"id\\":65,\\"error\\":{\\"code\\":-32000,\\"message\\":\\"nonce too low\\"}}","error":{"code":-32000},"requestBody":"{\\"method\\":\\"eth_sendRawTransaction\\",\\"params\\":[\\"0x02f89105821b6f846259008084625ce33e8254589441ee0c359d95970a83229d8e9801cc267239021780a50f01711220337eb7b11ff378b7f64e8d1a16bed17ffc2e0d4a69e0245a973396fa2a8f4be0c080a0415b4dfd2157f507aa3bfc0e832d1b6960afec5a5c1fe4cfbc63072d36ab49d6a072447e5a3228553dfa145982f6f6d527542ea8f742c8db6976d7dbf847024e59\\"],\\"id\\":65,\\"jsonrpc\\":\\"2.0\\"}","requestMethod":"POST","url":"https://goerli.infura.io/v3/b6685df41e1647c4be0046dfa62a020b"}, method="sendTransaction", transaction="0x02f89105821b6f846259008084625ce33e8254589441ee0c359d95970a83229d8e9801cc267239021780a50f01711220337eb7b11ff378b7f64e8d1a16bed17ffc2e0d4a69e0245a973396fa2a8f4be0c080a0415b4dfd2157f507aa3bfc0e832d1b6960afec5a5c1fe4cfbc63072d36ab49d6a072447e5a3228553dfa145982f6f6d527542ea8f742c8db6976d7dbf847024e59", code=NONCE_EXPIRED, version=providers/5.7.2)'
2022-12-11T00:51:41.726-05:00	[Sun, 11 Dec 2022 05:51:41 GMT] service=db type=request action=update id=65f42dd4-40a3-4beb-ae49-534bf3d9063a status=0 pinned=true createdAt=1670737762326 updatedAt="Sun Dec 11 2022 05:51:41 GMT+0000 (Coordinated Universal Time)" cid=bagcqceramcedgk3eb25rwp2mkf4hth7axxrp7fscm7qosgs4foubzltafnya streamId=kjzl6cwe1jw14asaqhgnquz9359pc053z537e5ias9fnojdjqyxvstjxruuz6pz message="Request is pending."
2022-12-11T00:51:41.730-05:00	[Sun, 11 Dec 2022 05:51:41 GMT] service=anchor type=anchorRequests acceptedRequestsCount=1 alreadyAnchoredRequestsCount=0 anchoredRequestsCount=0 conflictingRequestCount=0 failedRequestsCount=0 failedToPublishAnchorCommitCount=0 unprocessedRequestCount=0 pendingRequestsCount=1 candidateCount=1 anchorCount=0 canRetryCount=1 reanchoredCount=0
2022-12-11T00:51:41.731-05:00	[2022-12-11T05:51:41.731Z] ERROR: 'Error when anchoring: Error: nonce has already been used [ See: https://links.ethers.org/v5-errors-NONCE_EXPIRED ] (error={"reason":"processing response error","code":"SERVER_ERROR","body":"{\\"jsonrpc\\":\\"2.0\\",\\"id\\":65,\\"error\\":{\\"code\\":-32000,\\"message\\":\\"nonce too low\\"}}","error":{"code":-32000},"requestBody":"{\\"method\\":\\"eth_sendRawTransaction\\",\\"params\\":[\\"0x02f89105821b6f846259008084625ce33e8254589441ee0c359d95970a83229d8e9801cc267239021780a50f01711220337eb7b11ff378b7f64e8d1a16bed17ffc2e0d4a69e0245a973396fa2a8f4be0c080a0415b4dfd2157f507aa3bfc0e832d1b6960afec5a5c1fe4cfbc63072d36ab49d6a072447e5a3228553dfa145982f6f6d527542ea8f742c8db6976d7dbf847024e59\\"],\\"id\\":65,\\"jsonrpc\\":\\"2.0\\"}","requestMethod":"POST","url":"https://goerli.infura.io/v3/b6685df41e1647c4be0046dfa62a020b"}, method="sendTransaction", transaction="0x02f89105821b6f846259008084625ce33e8254589441ee0c359d95970a83229d8e9801cc267239021780a50f01711220337eb7b11ff378b7f64e8d1a16bed17ffc2e0d4a69e0245a973396fa2a8f4be0c080a0415b4dfd2157f507aa3bfc0e832d1b6960afec5a5c1fe4cfbc63072d36ab49d6a072447e5a3228553dfa145982f6f6d527542ea8f742c8db6976d7dbf847024e59", code=NONCE_EXPIRED, version=providers/5.7.2)'
2022-12-11T00:51:41.731-05:00	[2022-12-11T05:51:41.731Z] ERROR: 'Exiting'

ukstv
ukstv reviewed May 17, 2023
View reviewed changes
src/models/transaction.ts
@@ -1,13 +1,11 @@
export class Transaction {
chain: string
txHash: string
blockNumber: number
blockTimestamp: number
blockNumber: bigint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind if I ask you what happened to the timestamp?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not part of the transaction receipt from viem. Still need to figure out if there's a way for me to get that. Possibly by grabbing the block.

ukstv
ukstv reviewed May 17, 2023
View reviewed changes
src/services/blockchain/ethereum/ethereum-blockchain-service.ts Outdated

constructor(config: Config, private readonly wallet: ethers.Wallet) {
this.useSmartContractAnchors = config.useSmartContractAnchors
constructor(config: Config, private readonly provider: PublicClient, private readonly wallet: WalletClient, private readonly walletAddress: Address) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is safer IMO to not mix private readonly constructor properties with property declarations like on 161-166. It makes it complicated to see what is actually available. IMO.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, will adjust that.

@ukstv
Copy link
Contributor

ukstv commented May 29, 2023

Hey @dbcfd any news on the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukstv ukstv ukstv left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbcfd @ukstv