Open
Conversation
Signed-off-by: Raja Sharma <raja@ibm.com>
Member
Author
cbodley
reviewed
May 6, 2025
Comment on lines
+1489
to
+1490
| # Cleanup | ||
| iam_root.delete_policy(PolicyArn=policy['Policy']['Arn']) |
Contributor
There was a problem hiding this comment.
once we support iam:ListPolicies, we can add a nuke_policies() to the iam_root/iam_alt_root fixtures in iam.py so that test cases don't have to handle cleanup on their own
| user_policy | ||
| versioning | ||
| webidentity_test | ||
| policy |
Contributor
There was a problem hiding this comment.
can we call this managed_policy?
Member
Author
There was a problem hiding this comment.
@cbodley overall related to this SPIKE can we call managed_policy instead of policy or customer_managed_policy ?
but there is other existing features related managed_policy in will that create any confusion?
rgw_rest_user_policy.cc
Member
Author
There was a problem hiding this comment.
but AWS presents it as policy while create, delete, get etc
|
|
||
| @pytest.mark.policy | ||
| @pytest.mark.iam_account | ||
| def test_get_policy(iam_root): |
Contributor
There was a problem hiding this comment.
you can add a get test for a non existent policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.