Skip to content

qa/rgw/verify: pick random addressing_style={path,virtual}#66031

Open
cbodley wants to merge 4 commits intoceph:mainfrom
cbodley:wip-qa-rgw-vhost
Open

qa/rgw/verify: pick random addressing_style={path,virtual}#66031
cbodley wants to merge 4 commits intoceph:mainfrom
cbodley:wip-qa-rgw-vhost

Conversation

@cbodley
Copy link
Contributor

@cbodley cbodley commented Oct 22, 2025

rgw/verify suite tests both path-style and vhost-style access with s3-tests. the virtual style requires dnsmasq for wildcard dns, and matching rgw configuration of rgw_dns_name

depends on ceph/s3-tests#702
needed to enable testing of s3control in #64293

Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

@cbodley
Copy link
Contributor Author

cbodley commented Oct 24, 2025

the virtual.yaml configuration causes qa/workunits/rgw/run-admin-pagination.sh to fail:

An error occurred (NoSuchBucket) when calling the ListBuckets operation: None

when rgw_dns_name is configured, this causes us to misinterpret ListBuckets requests with Host: localhost as a ListObjects request on the bucket 'localhost'

to enable rgw_dns_name in rgw/verify, we'd have to fix all our various test scripts to use the right dns name instead of localhost

calling_format was only supported for the boto2 test cases. use
botocore's addressing_style option instead

Signed-off-by: Casey Bodley <cbodley@redhat.com>
virtual.yaml uses dnsmasq for a wildcard dns name, and configures
rgw_dns_name to use it

Signed-off-by: Casey Bodley <cbodley@redhat.com>
support definition of an empty dnsmasq task like:
> - dnsmasq:

that then gets overrides like:
> overrides:
>   dnsmasq:
>     client.0:
>       s3.: client.0

without this change, the dnsmasq task fails with:
>  File "qa/tasks/dnsmasq.py", line 127, in task
>     overrides = config.get('overrides', {})
> AttributeError: 'NoneType' object has no attribute 'get'

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley cbodley force-pushed the wip-qa-rgw-vhost branch 2 times, most recently from a5245c1 to 4a23e8b Compare November 19, 2025 16:13
for vhost-style access, the client needs to use the configured dns name
instead of localhost. qa/tasks/rgw.py writes the fully-qualified http
endpoint url to a file under $TESTDIR, so try that first before falling
back to localhost endpoints

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants