rgw/sts: correct error code to 400 (from 403)#65847
rgw/sts: correct error code to 400 (from 403)#65847pritha-srivastava wants to merge 2 commits intoceph:mainfrom
Conversation
588c735 to
8b8ce94
Compare
|
jenkins test windows |
cbodley
left a comment
There was a problem hiding this comment.
i was hoping that EPERM would already do the right thing, but i see that only swift maps it to '401 Unauthorized' while s3 maps it to 403. i wonder if any other uses of EPERM in rgw_rest_s3.cc should map to 401 too?
the mappings in rgw_common.cc:
rgw_http_errors rgw_http_s3_errors({
...
{ EACCES, {403, "AccessDenied" }},
{ EPERM, {403, "AccessDenied" }},
...
rgw_http_errors rgw_http_swift_errors({
{ EACCES, {403, "AccessDenied" }},
{ EPERM, {401, "AccessDenied" }},
|
needs to be tested against ceph/s3-tests#700 for qa |
|
@pritha-srivastava, It doesn't appear as though the testing was updated to reflect these changes. In @anrao19 's QE run with this PR we're getting this error: I'm removing the QE tracker: https://tracker.ceph.com/issues/73576 |
|
@ivancich : I am still waiting to figure out what the correct error code should be here, so this can be left out from the qe jobs as of now. I will test it later when I am sure of the error code. |
8b8ce94 to
2c57a96
Compare
|
https://jenkins.ceph.com/job/ceph-pull-requests-arm64/83245/
commented again in https://tracker.ceph.com/issues/46875 |
|
jenkins test make check arm64 |
7a8361c to
18c624a
Compare
18c624a to
aadf20b
Compare
for expires sts credentials. Fixes: https://tracker.ceph.com/issues/73441 Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
aadf20b to
8d0ae97
Compare
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
for expires sts credentials.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.