Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw_lc: stop using merge_and_store_attrs in remove_bucket_config #57530

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mattbenjamin
Copy link
Contributor

@mattbenjamin mattbenjamin commented May 16, 2024

This is a cleanup, but tracks a fix for failure to delete lifecycle config see on (downstream) Reef.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@mattbenjamin
Copy link
Contributor Author

this is a cleanup on main, but on downstream 7.1 (based on Reef), it's a bug fix

@cbodley
Copy link
Contributor

cbodley commented May 17, 2024

src/rgw/driver/rados/rgw_sal_rados.cc:369:20: error: unused variable 'merge_attrs' [-Werror,-Wunused-variable]
    constexpr bool merge_attrs = false; // don't update xattrs, we're deleting
                   ^
1 error generated.

This is a cleanup, but tracks a fix for failure to delete lifecycle
config see on (downstream) Reef.

Signed-off-by: Matt Benjamin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants