rbd: cleanup some parts in the ControllerServer #5101
+100
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpanic
force-pushed
the
cleanup/rbd/controllerserver
branch
from
8773c14 to
24a66af
Compare
Madhu-1
reviewed
Jan 30, 2025
| log.DebugLog(ctx, "created image %s backed for request name %s", rbdVol, rbdVol.RequestName) | ||
| requestName, err := rbdVol.GetRequestName(ctx) | ||
| if err != nil { | ||
| requestName = "<unset request name>" |
There was a problem hiding this comment.
@nixpanic why is this special case not an error case?
There was a problem hiding this comment.
It is only used for logging, and was not an error before this change.
Madhu-1
previously approved these changes
Feb 3, 2025
iPraveenParihar
previously approved these changes
Feb 4, 2025
|
/test ci/centos/mini-e2e/k8s-1.32 |
|
@nixpanic, the ci test failed |
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
Signed-off-by: Niels de Vos <[email protected]>
The RBD ControllerService does not expose the `PUBLISH_UNPUBLISH_VOLUME` capability, so ControllerPublishVolume and ControllerUnpublishVolume will never get called. In case a broken Container Orchestrator does call these operations, a default Unimplemented error will be returned anyway. Signed-off-by: Niels de Vos <[email protected]>
Thanks! It looks like |
nixpanic
force-pushed
the
cleanup/rbd/controllerserver
branch
from
24a66af to
6d8882f
Compare
|
/test ci/centos/mini-e2e/k8s-1.32 |
mergify
bot
dismissed stale reviews from Madhu-1 and iPraveenParihar
Pull request has been modified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous cleanups. This should help in restructuring the rbd package with cleaner APIs. Eventually the
rbdImage,rbdVolumeandrbdSnapshottypes should be used as a interface/type similar toVolumeGroupprovided by theinternal/rbd/grouppackage.move
cleanUpImageAndSnapReservation()intorbdSnapshot.Delete()make
RequestNameinternal torbdVolumeuse
rbd.ManagerwithinControllerServer.DeleteVolume()andControllerServer.DeleteSnapshot()Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)