Remove quincy builds/mentions from most builds/build configs. #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intentionally leaving the map from number to name in build_utils.sh for historical purposes. Signed-off-by: Dan Mick <[email protected]>
dmick
force-pushed
the
wip-remove-quincy
branch
from
92b622d to
66c3c98
Compare
|
ping for review |
yuriw
approved these changes
Jan 15, 2025
|
ping again. reviewers, please have a look and make sure I'm not breaking something you or someone you know is relying on |
djgalloway
approved these changes
Jan 21, 2025
|
@travisn @cbodley @neha-ojha @ljflores please review |
travisn
approved these changes
Jan 22, 2025
ljflores
reviewed
Jan 27, 2025
There was a problem hiding this comment.
Noticing a few references to quincy still remain on your branch:
$ git grep "quincy"
attic/ceph-container-build-ceph-base-push-imgs-arm64/config/definitions/ceph-container-build-ceph-base-push-imgs-arm64.yml: default: "pacific,centos,8 quincy,centos,8 reef,centos,8"
attic/ceph-container-build-ceph-base-push-imgs/config/definitions/ceph-container-build-ceph-base-push-imgs.yml: default: "pacific,centos,8 quincy,centos,8 reef,centos,8"
attic/ceph-dev-trigger/config/definitions/ceph-dev-trigger.yml: - 'origin/quincy'
attic/ceph-dev-trigger/config/definitions/ceph-dev-trigger.yml: # build quincy on:
attic/ceph-dev-trigger/config/definitions/ceph-dev-trigger.yml: regex: .*quincy.*
ceph-rook-e2e/config/definitions/ceph-orchestrator-rook-e2e.yml: - quincy
scripts/build_utils.sh: rel="quincy"
Not sure if all should be removed, but it's worth checking. Especially:
- attic/ceph-dev-trigger/config/definitions/ceph-dev-trigger.yml
- attic/ceph-container-build-ceph-base-push-imgs/config/definitions/ceph-container-build-ceph-base-push-imgs.yml
- attic/ceph-container-build-ceph-base-push-imgs-arm64/config/definitions/ceph-container-build-ceph-base-push-imgs-arm64.yml
The other two files seem to have other older versions it them, so I would keep quincy there.
Edit: I see your comment about leaving build_utils.sh; I agree with this, it should be left. So that leaves the stuff under attic.
|
@ljflores attic is intentionally "removed, no longer maintained" jobs and isn't active |
ljflores
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intentionally leaving the map from number to name in build_utils.sh for historical purposes.
I need folks to carefully review this, as I've not only removed quincy from some places, but also older releases (this should help clean up the build matrix displays in Jenkins for clarity as well). Please suggest/add other reviewers for areas of expertise.