Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ceph-dev-pipeline #2310

Merged
merged 9 commits into from
Feb 6, 2025
Merged

Add ceph-dev-pipeline #2310

merged 9 commits into from
Feb 6, 2025

Conversation

zmc
Copy link
Member

@zmc zmc commented Dec 27, 2024

This may ultimately replace the existing ceph-*build jobs; for now, it is a
work in-progress.

@zmc zmc requested review from dmick and djgalloway December 27, 2024 17:09
@zmc
Copy link
Member Author

zmc commented Dec 27, 2024

#!/bin/bash
# vim: ts=4 sw=4 expandtab
set -ex
PS4="\$(date --rfc-3339=seconds) + "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL... 👏

@djgalloway
Copy link
Contributor

Incredible work. I have no qualms, suggestions, or nits.

@zmc
Copy link
Member Author

zmc commented Jan 10, 2025

I wanted to set up label-based triggers to run this pipeline on ceph PRs, but it seems like I'd need to move the Jenkinsfile to the ceph repository to make that happen.

Edit: Using the generic webhook trigger plugin, we can do this without moving the Jenkinsfile. This PR is only targeting push-based trigger.

@zmc zmc force-pushed the jenkinsfile branch 2 times, most recently from d8cbb97 to f33931b Compare January 17, 2025 19:56
@zmc zmc force-pushed the jenkinsfile branch 4 times, most recently from bb60f28 to cbb5364 Compare January 30, 2025 19:59
zmc added 3 commits January 30, 2025 13:08
This may ultimately replace the existing ceph-*build jobs; for now, it is a
work in-progress.

Signed-off-by: Zack Cerza <[email protected]>
@zmc zmc force-pushed the jenkinsfile branch 2 times, most recently from 6e1bf10 to 177d2d0 Compare January 30, 2025 21:14
@zmc
Copy link
Member Author

zmc commented Jan 30, 2025

I think this is complete enough to be merged (after removing the temporary commit and updating branch names). We also ought to document this new pipeline, but I couldn't find any documentation on the ceph-dev-{new-,} jobs to add to.

@zmc
Copy link
Member Author

zmc commented Jan 30, 2025

Once we merge this it might make sense to branch it to see about integrating ceph/ceph#59841

zmc added 6 commits February 5, 2025 12:53
This job serves to trigger ceph-dev-pipeline via webhook payloads, but is
opt-in. This implementation initially targets only GitHub push event payloads.
On each push, it will inspect the head commit for [git trailers][0]. The trailer
required to opt in is "CI-PIPELINE: true". If that trailer is found, the job
looks for these others:

ARCHS, CI_COMPILE, CI_CONTAINER, CI_PIPELINE, DISTROS, DWZ, FLAVOR, SCCACHE

Any that are found are passed as parameters.

[0] https://git-scm.com/docs/git-interpret-trailers

Signed-off-by: Zack Cerza <[email protected]>
BRANCH, DISTROS, ARCHS, SETUP_BUILD_ID with a link to the setup build.

Signed-off-by: Zack Cerza <[email protected]>
@zmc zmc marked this pull request as ready for review February 5, 2025 19:54
@zmc zmc mentioned this pull request Feb 6, 2025
14 tasks
Copy link
Member

@dmick dmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one comment about podman login is all I really see to discuss at this point. This is great work, and although I'm not necessarily looking forward to maintaining Groovy, this is clearly the right Jenkins direction.

@dmick dmick self-requested a review February 6, 2025 19:43
Comment on lines +4 to +12
ubuntu_releases = [
"noble", // 24.04
"jammy", // 22.04
"focal", // 20.04
]
debian_releases = [
"bookworm", // v12 (2023)
"bullseye", // v11 (2021)
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Embarrassing question... Why is there no RPM distro list?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since those distros don't use codenames, we can use a regex like ^(centos|rhel|fedora).* - we don't need lists.

@zmc zmc merged commit 878c28e into main Feb 6, 2025
1 check passed
@zmc zmc deleted the jenkinsfile branch February 6, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants