Skip to content

Chore: Add the clientname option for fio and librbdfio #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rfakit
Copy link

@rfakit rfakit commented May 30, 2025

Add clientname option for fio and librbdfio benchmarks

Description

This PR adds a configurable clientname option to both the fio and librbdfio benchmark classes in CBT. This enhancement allows users to specify a custom client name when running FIO benchmarks against RBD endpoints, rather than being limited to the hardcoded 'admin' client name.

Changes

  • Added clientname configuration option to Fio class with a default value of 'admin'
  • Added clientname configuration option to LibrbdFio class with a default value of 'admin'
  • Updated FIO command construction to use the configured clientname in both classes
  • Modified prefill command in LibrbdFio to use the configured clientname

Testing

The changes have been tested with:

  • Default configuration (clientname = 'admin')
  • Custom clientname configuration
  • Both fio and librbdfio benchmark types
  • Various RBD endpoint configurations

Usage Example

benchmarks:
  librbdfio:
    clientname: 'custom_client'  # Optional, defaults to 'admin'
    time: 300
    vol_size: 16384
    mode: [read, write]
    # ... other configuration options ...

Impact

This change is backward compatible as it maintains the default 'admin' clientname if not specified in the configuration. Users who don't specify a clientname will see no change in behavior.

Related Issues

N/A

Checklist

  • Code follows the project's coding style
  • Documentation has been updated (if applicable)
  • Tests have been added/updated (if applicable)
  • All tests pass
  • Changes are backward compatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant