Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible restrictions #210

Merged
merged 9 commits into from
Nov 17, 2023
Merged

Flexible restrictions #210

merged 9 commits into from
Nov 17, 2023

Conversation

hieronx
Copy link
Contributor

@hieronx hieronx commented Nov 17, 2023

No description provided.

hieronx and others added 4 commits November 7, 2023 21:36
* setup flex restrictions

* remove test env

* fixes from review part 1

* fmt

* fix naming

* support addTranche messages without restrictionSet
@hieronx hieronx requested a review from AStox November 17, 2023 16:42
AStox
AStox previously approved these changes Nov 17, 2023
test/integration/AssetShareConversion.t.sol Outdated Show resolved Hide resolved
test/integration/AssetShareConversion.t.sol Outdated Show resolved Hide resolved
test/integration/Deposit.t.sol Outdated Show resolved Hide resolved
test/gateway/Messages.t.sol Outdated Show resolved Hide resolved
@ilinzweilin ilinzweilin requested a review from AStox November 17, 2023 17:32
Copy link

Coverage after merging flexible-restrictions into main will be

81.87%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Escrow.sol100%100%100%100%
   InvestmentManager.sol91.44%70.97%97.22%98.11%145, 149, 154, 185, 189, 194, 234, 260, 310, 341, 417, 423–424, 454, 490–491, 534, 536, 580, 639–640
   LiquidityPool.sol95.24%80%97.44%98.51%101, 112, 128–129, 164
   PoolManager.sol95.89%87.14%100%100%177, 193, 219, 230, 311, 319, 331, 336, 362
   Root.sol100%100%100%100%
   UserEscrow.sol100%100%100%100%
src/admins
   DelayedAdmin.sol100%100%100%100%
   PauseAdmin.sol100%100%100%100%
src/gateway
   Gateway.sol94.59%83.33%100%98.88%336, 348, 360, 373, 386, 389, 405, 412
   Messages.sol63.44%37.50%60.47%65.95%1000, 1000, 1000–1001, 1005, 105, 124, 155, 208, 216, 251, 296–299, 395, 403–407, 431, 439, 463, 471, 495, 503, 523, 531–534, 554, 562–565, 576, 619, 663, 710, 749, 761, 787, 824–827, 843–846, 857, 86, 883, 906, 936, 967–968, 970–971, 971, 971–972, 974, 978, 982, 999
src/gateway/routers/axelar
   Router.sol100%100%100%100%
src/gateway/routers/xcm
   Router.sol0%0%0%0%103, 103, 103–104, 106, 109, 114, 119, 121, 123, 142, 157, 157, 157–159, 159, 159, 161–162, 162, 162–164, 164, 164–166, 166, 166–168, 168, 168–170, 170, 170–172, 172, 172–173, 175, 182–183, 185, 189–191, 193, 197, 90, 90, 90–91, 93, 96
src/token
   ERC20.sol95.42%92.86%92.86%97.33%199, 228, 67, 85–86
   RestrictionManager.sol93.62%87.50%100%95.65%71–72, 96
   Tranche.sol92.68%100%75%100%
src/util
   Auth.sol100%100%100%100%
   BytesLib.sol0%0%0%0%10, 10, 10, 102, 102, 102–103, 106, 109, 11, 11, 11, 113, 113, 113–114, 117, 120, 124, 124, 124–125, 128, 13, 131, 65, 69, 69, 69–70, 73, 76, 80, 80, 80–81, 84, 87, 91, 91, 91–92, 95, 98
   Factory.sol100%100%100%100%
   MathLib.sol0%0%0%0%105–106, 106, 106–107, 109, 114, 114, 114–115, 117, 24–25, 28–29, 33, 33, 33, 37, 41, 41, 41, 48, 51, 54–55, 63, 66, 69, 72, 76, 81, 86–91, 97–98
   SafeTransferLib.sol87.50%66.67%100%100%28, 38

@ilinzweilin ilinzweilin self-requested a review November 17, 2023 17:54
@ilinzweilin ilinzweilin merged commit 380f0b9 into main Nov 17, 2023
4 checks passed
@hieronx hieronx deleted the flexible-restrictions branch August 6, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants