Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message recovery follow ups #1975

Merged
merged 2 commits into from
Aug 17, 2024
Merged

Conversation

cdamian
Copy link
Contributor

@cdamian cdamian commented Aug 17, 2024

Fixes

@cdamian
Copy link
Contributor Author

cdamian commented Aug 17, 2024

Draft to avoid triggering a CI run.

@cdamian cdamian requested review from lemunozm and wischli and removed request for lemunozm August 17, 2024 12:20
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@cdamian cdamian marked this pull request as ready for review August 17, 2024 12:30
@cdamian cdamian merged commit 35248da into cleanings-pre-audit Aug 17, 2024
5 of 7 checks passed
@cdamian cdamian deleted the message-recovery-follow-ups branch August 17, 2024 12:30
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (cleanings-pre-audit@a29e723). Learn more about missing BASE report.

Files Patch % Lines
pallets/liquidity-pools/src/message.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             cleanings-pre-audit    #1975   +/-   ##
======================================================
  Coverage                       ?   48.93%           
======================================================
  Files                          ?      183           
  Lines                          ?    13135           
  Branches                       ?        0           
======================================================
  Hits                           ?     6427           
  Misses                         ?     6708           
  Partials                       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lemunozm added a commit that referenced this pull request Aug 18, 2024
* move pallet-liquidity-pools-gateway to pallets

* support for events in RuntimeEnv

* fix docs

* queue traits to its own file

* add queue() name

* Message recovery follow ups (#1975)

* lp-message: Use MessageHash for recovery fns

* lp-gateway: Drop domain from message recovery extrinsics

* revert moving queue traits to its own file

* rename liquidity_pools.rs to foreign_investments.rs

* remove default and fix IT

* move axelar utility to axelar

---------

Co-authored-by: Cosmin Damian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants