Latest cleanings pre audit #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
force-pushed
the
cleanings-pre-audit
branch
from
d902431 to
bfe3777
Compare
cdamian
reviewed
Aug 17, 2024
| @@ -235,7 +235,7 @@ pallet-investments = { path = "pallets/investments", default-features = false } | |||
| pallet-keystore = { path = "pallets/keystore", default-features = false } | |||
| pallet-liquidity-pools = { path = "pallets/liquidity-pools", default-features = false } | |||
| pallet-liquidity-pools-gateway = { path = "pallets/liquidity-pools-gateway", default-features = false } | |||
| pallet-liquidity-pools-gateway-queue = { path = "pallets/liquidity-pools-gateway/queue", default-features = false } | |||
| pallet-liquidity-pools-gateway-queue = { path = "pallets/liquidity-pools-gateway-queue", default-features = false } | |||
There was a problem hiding this comment.
I think we can leave this name as it is.
There was a problem hiding this comment.
But then it would look weird if the pallet is being used for another kind of queues...
There was a problem hiding this comment.
That's a problem for future-us :D Plus, I think that eventually we'll drop it and use Tasks.
There was a problem hiding this comment.
I'm not convinced by the name, but I will leave it as it
6 tasks
* lp-message: Use MessageHash for recovery fns * lp-gateway: Drop domain from message recovery extrinsics
lemunozm
force-pushed
the
cleanings-pre-audit
branch
from
4644783 to
1101a64
Compare
|
If passes CI, that it should, we can merge it |
cdamian
previously approved these changes
Aug 18, 2024
|
I've moved some utility into axelar to be audited as part of the pallet: cd7c3d0 |
wischli
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR with some cleanings to be merged just before the audit, after:
Changes:
pallet-liquidity-pools-queuemoved topallets/traits/liquidity_pools.rs(they are generic enough)renamed topallet-queueorpallet-idle-queuecases/liquidity_pools.rsrenamed tocases/foreign_investments.rs