Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add increase & decrease debt to borrow proxy #1944

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

lemunozm
Copy link
Contributor

@lemunozm lemunozm commented Aug 1, 2024

Description

@lemunozm lemunozm added the I8-enhancement An additional feature. label Aug 1, 2024
@lemunozm lemunozm requested review from hieronx and wischli August 1, 2024 15:38
@lemunozm lemunozm self-assigned this Aug 1, 2024
@lemunozm
Copy link
Contributor Author

lemunozm commented Aug 1, 2024

Should we add also this to the NonTransfer proxy? It seems like other loans actions are there

wischli
wischli previously approved these changes Aug 1, 2024
@hieronx
Copy link
Contributor

hieronx commented Aug 1, 2024

Should we add also this to the NonTransfer proxy? It seems like other loans actions are there

Yes I would say so

@lemunozm lemunozm enabled auto-merge (squash) August 1, 2024 16:42
@lemunozm lemunozm requested a review from wischli August 1, 2024 16:43
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.78%. Comparing base (b682138) to head (76c8ab7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1944      +/-   ##
==========================================
- Coverage   47.79%   47.78%   -0.02%     
==========================================
  Files         184      184              
  Lines       13038    13038              
==========================================
- Hits         6232     6230       -2     
- Misses       6806     6808       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@lemunozm lemunozm merged commit 7070f0f into main Aug 1, 2024
11 checks passed
@wischli wischli deleted the feat/increase-decrease-debt-borrow branch August 1, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I8-enhancement An additional feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants