Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-wasm-upload #1932

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Fix-wasm-upload #1932

merged 4 commits into from
Aug 1, 2024

Conversation

gpmayorga
Copy link
Contributor

Description

[description]

Fixes #(issue)

Changes and Descriptions

[List your changes here]

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@gpmayorga gpmayorga requested a review from wischli as a code owner July 29, 2024 13:22
@gpmayorga gpmayorga marked this pull request as draft July 29, 2024 13:22
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.92%. Comparing base (c4e1400) to head (2b75c2c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1932      +/-   ##
==========================================
- Coverage   47.95%   47.92%   -0.04%     
==========================================
  Files         181      181              
  Lines       13159    13159              
==========================================
- Hits         6311     6306       -5     
- Misses       6848     6853       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wischli
wischli previously approved these changes Jul 29, 2024
@wischli
Copy link
Contributor

wischli commented Jul 30, 2024

@gpmayorga Anything pending for this PR? We need it merged ASAP because we need to create an RC for a RU this week

@gpmayorga gpmayorga marked this pull request as ready for review August 1, 2024 06:47
@wischli wischli merged commit 1edf2b0 into main Aug 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants