Skip to content

Commit

Permalink
lp-gateway: Add more asserts in unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@cdamian
cdamian committed Aug 13, 2024
1 parent feee363 commit d9754ff
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 53 deletions.
6 changes: 3 additions & 3 deletions libs/mocks/src/router_message.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
pub mod pallet {
use cfg_traits::liquidity_pools::{MessageReceiver, MessageSender};
use frame_support::pallet_prelude::*;
use mock_builder::{execute_call, register_call};
use mock_builder::{execute_call, register_call, CallHandler};

#[pallet::config]
pub trait Config: frame_system::Config {
Expand All @@ -25,8 +25,8 @@ pub mod pallet {

pub fn mock_send(
f: impl Fn(T::Middleware, T::Origin, Vec<u8>) -> DispatchResult + 'static,
) {
register_call!(move |(a, b, c)| f(a, b, c));
) -> CallHandler {
register_call!(move |(a, b, c)| f(a, b, c))
}
}

Expand Down
93 changes: 43 additions & 50 deletions pallets/liquidity-pools-gateway/src/tests.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ mod receive_message_domain {
router_id: router_id.clone(),
};

MockLiquidityPoolsGatewayQueue::mock_submit(move |mock_message| {
let handler = MockLiquidityPoolsGatewayQueue::mock_submit(move |mock_message| {
assert_eq!(mock_message, gateway_message);
Ok(())
});
Expand All @@ -315,6 +315,8 @@ mod receive_message_domain {
router_id,
BoundedVec::<u8, MaxIncomingMessageSize>::try_from(encoded_msg).unwrap()
));

assert_eq!(handler.times(), 1);
});
}

Expand Down Expand Up @@ -430,7 +432,7 @@ mod outbound_message_handler_impl {
BoundedVec::try_from(vec![ROUTER_ID_1, ROUTER_ID_2, ROUTER_ID_3]).unwrap(),
));

MockLiquidityPoolsGatewayQueue::mock_submit(move |mock_msg| {
let handler = MockLiquidityPoolsGatewayQueue::mock_submit(move |mock_msg| {
match mock_msg {
GatewayMessage::Inbound { .. } => {
assert!(false, "expected outbound message")
Expand All @@ -453,11 +455,12 @@ mod outbound_message_handler_impl {
});

assert_ok!(LiquidityPoolsGateway::handle(sender, domain, msg));
assert_eq!(handler.times(), 3);
});
}

#[test]
fn local_domain() {
fn domain_not_supported() {
new_test_ext().execute_with(|| {
let domain = Domain::Centrifuge;
let sender = get_test_account_id();
Expand All @@ -471,25 +474,35 @@ mod outbound_message_handler_impl {
}

#[test]
fn message_queue_error() {
fn routers_not_found() {
new_test_ext().execute_with(|| {
let domain = Domain::EVM(0);
let sender = get_test_account_id();
let msg = Message::Simple;

let router_id_1 = ROUTER_ID_1;
let router_id_2 = ROUTER_ID_2;
let router_id_3 = ROUTER_ID_3;
assert_noop!(
LiquidityPoolsGateway::handle(sender, domain, msg),
Error::<Runtime>::RoutersNotFound
);
});
}

#[test]
fn message_queue_error() {
new_test_ext().execute_with(|| {
let domain = Domain::EVM(0);
let sender = get_test_account_id();
let msg = Message::Simple;

assert_ok!(LiquidityPoolsGateway::set_routers(
RuntimeOrigin::root(),
BoundedVec::try_from(vec![router_id_1.clone(), router_id_2, router_id_3]).unwrap(),
BoundedVec::try_from(vec![ROUTER_ID_1, ROUTER_ID_2, ROUTER_ID_3]).unwrap(),
));

let gateway_message = GatewayMessage::Outbound {
sender: <Runtime as Config>::Sender::get(),
message: msg.clone(),
router_id: router_id_1,
router_id: ROUTER_ID_1,
};

let err = DispatchError::Unavailable;
Expand Down Expand Up @@ -523,7 +536,7 @@ mod set_domain_hook {
}

#[test]
fn failure_bad_origin() {
fn bad_origin() {
new_test_ext().execute_with(|| {
let domain = Domain::EVM(0);

Expand All @@ -539,7 +552,7 @@ mod set_domain_hook {
}

#[test]
fn failure_centrifuge_domain() {
fn domain_not_supported() {
new_test_ext().execute_with(|| {
let domain = Domain::Centrifuge;

Expand Down Expand Up @@ -2422,18 +2435,16 @@ mod message_processor_impl {
new_test_ext().execute_with(|| {
let domain_address = DomainAddress::EVM(1, [1; 20]);

let router_id = ROUTER_ID_1;

Routers::<Runtime>::set(Some(
BoundedVec::try_from(vec![router_id.clone()]).unwrap(),
BoundedVec::try_from(vec![ROUTER_ID_1.clone()]).unwrap(),
));
SessionIdStore::<Runtime>::set(Some(1));

let message = Message::Simple;
let gateway_message = GatewayMessage::Inbound {
domain_address: domain_address.clone(),
message: message.clone(),
router_id,
router_id: ROUTER_ID_1,
};

let err = DispatchError::Unavailable;
Expand Down Expand Up @@ -2466,44 +2477,25 @@ mod message_processor_impl {
router_id: ROUTER_ID_1,
};

MockMessageSender::mock_send(move |mock_router_id, mock_sender, mock_message| {
assert_eq!(mock_router_id, ROUTER_ID_1);
assert_eq!(mock_sender, sender);
assert_eq!(mock_message, message.serialize());
let handler = MockMessageSender::mock_send(
move |mock_router_id, mock_sender, mock_message| {
assert_eq!(mock_router_id, ROUTER_ID_1);
assert_eq!(mock_sender, sender);
assert_eq!(mock_message, message.serialize());

Ok(())
});
Ok(())
},
);

let (res, weight) = LiquidityPoolsGateway::process(gateway_message);
assert_ok!(res);
assert!(weight.eq(&LP_DEFENSIVE_WEIGHT));
assert_eq!(handler.times(), 1);
});
}

//TODO(cdamian): Fix when bi-directional routers are in.
// #[test]
// fn router_not_found() {
// new_test_ext().execute_with(|| {
// let sender = get_test_account_id();
// let message = Message::Simple;
//
// let expected_weight = <Runtime as
// frame_system::Config>::DbWeight::get().reads(1);
//
// let gateway_message = GatewayMessage::Outbound {
// sender,
// message,
// router_id: ROUTER_ID_1,
// };
//
// let (res, weight) = LiquidityPoolsGateway::process(gateway_message);
// assert_noop!(res, Error::<Runtime>::RouterNotFound);
// assert_eq!(weight, expected_weight);
// });
// }

#[test]
fn router_error() {
fn message_sender_error() {
new_test_ext().execute_with(|| {
let sender = TEST_DOMAIN_ADDRESS;
let message = Message::Simple;
Expand Down Expand Up @@ -2561,7 +2553,7 @@ mod batches {
DOMAIN
));

let handle = MockLiquidityPoolsGatewayQueue::mock_submit(|_| Ok(()));
let handler = MockLiquidityPoolsGatewayQueue::mock_submit(|_| Ok(()));

// Ok Batched
assert_ok!(LiquidityPoolsGateway::handle(USER, DOMAIN, Message::Simple));
Expand All @@ -2586,15 +2578,15 @@ mod batches {
assert_ok!(LiquidityPoolsGateway::handle(USER, DOMAIN, Message::Simple));

// Two non-packed messages
assert_eq!(handle.times(), 2);
assert_eq!(handler.times(), 2);

assert_ok!(LiquidityPoolsGateway::end_batch_message(
RuntimeOrigin::signed(USER),
DOMAIN
));

// Packed message queued
assert_eq!(handle.times(), 3);
assert_eq!(handler.times(), 3);
});
}

Expand All @@ -2606,7 +2598,7 @@ mod batches {
DOMAIN
));

MockLiquidityPoolsGatewayQueue::mock_submit(|_| Ok(()));
let handler = MockLiquidityPoolsGatewayQueue::mock_submit(|_| Ok(()));

(0..MAX_PACKED_MESSAGES).for_each(|_| {
assert_ok!(LiquidityPoolsGateway::handle(USER, DOMAIN, Message::Simple));
Expand All @@ -2625,6 +2617,7 @@ mod batches {
RuntimeOrigin::signed(USER),
DOMAIN
));
assert_eq!(handler.times(), 1);
});
}

Expand Down Expand Up @@ -2799,7 +2792,7 @@ mod execute_message_recovery {
}

#[test]
fn inbound_domain_session_not_found() {
fn session_id_not_found() {
new_test_ext().execute_with(|| {
assert_noop!(
LiquidityPoolsGateway::execute_message_recovery(
Expand Down Expand Up @@ -2829,7 +2822,7 @@ mod execute_message_recovery {
}

#[test]
fn unknown_inbound_message_router() {
fn unknown_router() {
new_test_ext().execute_with(|| {
Routers::<Runtime>::set(Some(BoundedVec::try_from(vec![ROUTER_ID_1]).unwrap()));
SessionIdStore::<Runtime>::set(Some(1));
Expand Down

0 comments on commit d9754ff

Please sign in to comment.