Skip to content

Commit

Permalink
Fix review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
gpmayorga committed Nov 17, 2023
1 parent bfc67a5 commit 2fac7af
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

## Changes to .github
.github/* @mustermeiszer @NunoAlexandre @lemunozm
.github/workflows @gpmayorga
.github/actions @gpmayorga
.github/workflows @gpmayorga @wischli
.github/actions @gpmayorga @wischli

## Changes to ci
ci/* @mustermeiszer @NunoAlexandre @lemunozm
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/run-benchmarks.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
name: Run benchmarks
# ToDo: add an arbitrary label to keep this cache separate from the builds
on:
workflow_dispatch: # Manually triggered by an authorized repo contributor.
pull_request:
Expand All @@ -16,7 +15,7 @@ jobs:
runs-on: ubuntu-latest-8-cores
strategy:
matrix:
runtimes: [centrifuge, altair]
runtimes: [centrifuge, altair, development]
steps:
- name: Checkout code
uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac #v4
Expand Down
2 changes: 1 addition & 1 deletion docker/centrifuge-chain/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ FROM --platform=linux/amd64 docker.io/library/rust:bookworm as builder

# ===== SECOND STAGE ======
# ToDo: create a secure image as a base for the binary
FROM --platform=linux/amd64 docker.io/library/ubuntu:latest
FROM --platform=linux/amd64 docker.io/library/ubuntu:jammy

LABEL io.centrifuge.image.authors="[email protected]" \
io.centrifuge.image.vendor="Centrifuge" \
Expand Down

0 comments on commit 2fac7af

Please sign in to comment.