Skip to content

Comments

refactor: trigger upload with workflow_call#560

Merged
nicolasbrugneaux merged 2 commits intomasterfrom
chore/homebrew-fix
Mar 25, 2025
Merged

refactor: trigger upload with workflow_call#560
nicolasbrugneaux merged 2 commits intomasterfrom
chore/homebrew-fix

Conversation

@nicolasbrugneaux
Copy link
Contributor

@nicolasbrugneaux nicolasbrugneaux commented Mar 25, 2025

As figured out in https://github.com/orgs/community/discussions/25281#discussioncomment-3300251

the current workflow uploading executables cannot work, it just won't be called to prevent worfklow recursion.

Knowing that, I refactored the workflow to use workflow_call which is called in the release.yml


PR-Codex overview

This PR introduces a Perl script to assert the stability of the celocli version based on Semantic Versioning (SemVer) and updates the GitHub Actions workflow to incorporate this check during the release process.

Detailed summary

  • Added a new script scripts/assert_stable_version to validate celocli versions against SemVer.
  • Updated .github/workflows/release.yaml to include a step for asserting stable release.
  • Modified upload-celocli-executables.yml to assert stable version before uploading.
  • Enhanced version parsing in upload-celocli-executables.yml to use package.json.
  • Corrected file path in git add command for the formula file.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@nicolasbrugneaux nicolasbrugneaux requested a review from a team as a code owner March 25, 2025 09:35
@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2025

⚠️ No Changeset found

Latest commit: c16d7bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.91%. Comparing base (8ed8706) to head (c16d7bf).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #560   +/-   ##
=======================================
  Coverage   76.91%   76.91%           
=======================================
  Files         249      249           
  Lines       10698    10698           
  Branches     1710     1700   -10     
=======================================
  Hits         8228     8228           
- Misses       2362     2399   +37     
+ Partials      108       71   -37     
Components Coverage Δ
celocli 86.79% <ø> (ø)
sdk 69.54% <ø> (ø)
wallets 74.36% <ø> (ø)
viem-sdks 93.01% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nicolasbrugneaux nicolasbrugneaux merged commit 3cc0a8b into master Mar 25, 2025
23 of 36 checks passed
@nicolasbrugneaux nicolasbrugneaux deleted the chore/homebrew-fix branch March 25, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants