refactor: trigger upload with workflow_call#560
Merged
nicolasbrugneaux merged 2 commits intomasterfrom Mar 25, 2025
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
=======================================
Coverage 76.91% 76.91%
=======================================
Files 249 249
Lines 10698 10698
Branches 1710 1700 -10
=======================================
Hits 8228 8228
- Misses 2362 2399 +37
+ Partials 108 71 -37
🚀 New features to boost your workflow:
|
aaronmgdr
reviewed
Mar 25, 2025
aaronmgdr
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As figured out in https://github.com/orgs/community/discussions/25281#discussioncomment-3300251
the current workflow uploading executables cannot work, it just won't be called to prevent worfklow recursion.
Knowing that, I refactored the workflow to use
workflow_callwhich is called in therelease.ymlPR-Codex overview
This PR introduces a Perl script to assert the stability of the
celocliversion based on Semantic Versioning (SemVer) and updates the GitHub Actions workflow to incorporate this check during the release process.Detailed summary
scripts/assert_stable_versionto validatecelocliversions against SemVer..github/workflows/release.yamlto include a step for asserting stable release.upload-celocli-executables.ymlto assert stable version before uploading.upload-celocli-executables.ymlto usepackage.json.git addcommand for the formula file.