Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow users to use different apps than celo or ethereum #544

Merged
merged 3 commits into from
Mar 14, 2025

Conversation

nicolasbrugneaux
Copy link
Contributor

@nicolasbrugneaux nicolasbrugneaux commented Mar 14, 2025

Allow users to use other apps than ethereum or celo, namely eth recovery in order to recovery funds or signTypedData which isnt supported by celo but would require the correct derivationPath (which, in turn, isn't supported by ethereum)


PR-Codex overview

This PR introduces enhancements to the @celo/wallet-ledger and @celo/viem-account-ledger packages, allowing users to use other apps beyond Ethereum and Celo. It includes updated error handling and new tests for compatibility with unknown apps and other Ledger applications.

Detailed summary

  • Updated documentation to allow usage of apps like "eth recovery".
  • Replaced throw new Error with console.error for warnings about using non-Celo apps in packages/viem-account-ledger/src/utils.ts and packages/sdk/wallets/wallet-ledger/src/ledger-wallet.ts.
  • Added tests for compatibility with unknown apps in packages/viem-account-ledger/src/utils.test.ts.
  • Implemented tests for initialization warnings with the ethereum-recovery and ethereum apps in packages/sdk/wallets/wallet-ledger/src/ledger-wallet.test.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@nicolasbrugneaux nicolasbrugneaux requested a review from a team as a code owner March 14, 2025 10:42
Copy link

changeset-bot bot commented Mar 14, 2025

🦋 Changeset detected

Latest commit: 7fd2b4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@celo/wallet-ledger Patch
@celo/viem-account-ledger Patch
@celo/celocli Patch
@celo/wallet-base Patch
@celo/wallet-hsm-aws Patch
@celo/wallet-hsm-azure Patch
@celo/wallet-hsm-gcp Patch
@celo/wallet-hsm Patch
@celo/wallet-local Patch
@celo/wallet-remote Patch
@celo/contractkit Patch
@celo/keystores Patch
@celo/explorer Patch
@celo/governance Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.85%. Comparing base (385b3ac) to head (7fd2b4a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
+ Coverage   71.13%   76.85%   +5.71%     
==========================================
  Files         248      248              
  Lines       10674    10674              
  Branches     1695     1702       +7     
==========================================
+ Hits         7593     8203     +610     
+ Misses       2987     2361     -626     
- Partials       94      110      +16     
Components Coverage Δ
celocli 86.73% <ø> (ø)
sdk 69.47% <ø> (+11.44%) ⬆️
wallets 74.36% <100.00%> (+0.32%) ⬆️
viem-sdks 93.01% <100.00%> (-0.54%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aaronmgdr aaronmgdr force-pushed the fix/use-other-apps branch from 33bdc9a to 7fd2b4a Compare March 14, 2025 13:58
@aaronmgdr aaronmgdr merged commit 170e91c into master Mar 14, 2025
23 of 24 checks passed
@aaronmgdr aaronmgdr deleted the fix/use-other-apps branch March 14, 2025 14:11
@github-actions github-actions bot mentioned this pull request Mar 14, 2025
aaronmgdr pushed a commit that referenced this pull request Mar 14, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to master, this PR
will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`master` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `master`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @celo/[email protected]

### Minor Changes

- [#540](#540)
[`a92fa0c`](a92fa0c)
Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Add a
check to governance:propose for the flag descriptionURL. The checks
verifies that the URL points to the correct governance repository.

- [#535](#535)
[`c184fb1`](c184fb1)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - add lockedcelo:**_
alias for all lockedgold:_** commands

(tiny break): network:paramamters will output the contract name
LockedGold as LockedCelo now

### Patch Changes

- Updated dependencies
\[[`c184fb1`](c184fb1),
[`170e91c`](170e91c),
[`c184fb1`](c184fb1),
[`55f1e99`](55f1e99)]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Minor Changes

- [#535](#535)
[`c184fb1`](c184fb1)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Add CeloToken and
LockedCelo aliases for deprecated GoldToken and LockedCelo Contracts
enum

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- Updated dependencies
\[[`c184fb1`](c184fb1)]:
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#535](#535)
[`c184fb1`](c184fb1)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Ensure CeloToken
and LockedCelo can be used as aliases for GoldToken and LockedGold

- [#542](#542)
[`55f1e99`](55f1e99)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - When building
proposals if there is a failure show more informational error messages

- Updated dependencies
\[[`c184fb1`](c184fb1)]:
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#544](#544)
[`170e91c`](170e91c)
Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Allow
users to use other apps than ethereum or celo, namely "eth recovery" in
order to recovery funds or signTypedData which isnt supported by celo
but would require the correct derivationPath

-   Updated dependencies \[]:
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

-   Updated dependencies \[]:
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#544](#544)
[`170e91c`](170e91c)
Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Allow
users to use other apps than ethereum or celo, namely eth recovery in
order to recovery funds or signTypedData which isnt supported by celo
but would require the correct derivationPath (which, in turn, isn't
supported by ethereum)

## @celo/[email protected]



## @celo/[email protected]




<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily introduces `beta` versions for multiple packages in
the `Celo` SDK, updating their dependencies and changelogs. It aims to
enhance compatibility and introduce new features across various wallet
implementations.

### Detailed summary
- Updated version to `7.0.1-beta.0` for `@celo/wallet-base`,
`@celo/wallet-hsm`, `@celo/wallet-local`, `@celo/wallet-remote`, and
others.
- Introduced `5.0.15-beta.0` for `@celo/explorer` and `5.1.6-beta.0` for
`@celo/governance`.
- Updated dependencies for multiple packages to their corresponding
`beta` versions.
- Added new changelog entries for `@celo/contractkit`,
`@celo/viem-account-ledger`, and others, detailing recent changes and
enhancements.
- Included notable fixes and features, such as allowing users to recover
funds using other apps in `@celo/wallet-ledger`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`

<!-- end pr-codex -->

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Mar 24, 2025
aaronmgdr pushed a commit that referenced this pull request Mar 24, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to master, this PR
will be updated.


# Releases
## @celo/[email protected]

### Minor Changes

- [#540](#540)
[`a92fa0c`](a92fa0c)
Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Add a
check to governance:propose for the flag descriptionURL. The checks
verifies that the URL points to the correct governance repository.

- [#535](#535)
[`c184fb1`](c184fb1)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - add lockedcelo:**_
alias for all lockedgold:_** commands

(tiny break): network:paramamters will output the contract name
LockedGold as LockedCelo now

- [#533](#533)
[`549450f`](549450f)
Thanks [@soloseng](https://github.com/soloseng)! - added support for
epochManager processGroups function to contractkit && celocli

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- [#549](#549)
[`b6e4716`](b6e4716)
Thanks [@shazarre](https://github.com/shazarre)! - Hide extra output,
remove feedback postrun hook

- [#532](#532)
[`b4f560c`](b4f560c)
Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! -
Update oclif dependencies

- Updated dependencies
\[[`78f9831`](78f9831),
[`f11a069`](f11a069),
[`c184fb1`](c184fb1),
[`549450f`](549450f),
[`170e91c`](170e91c),
[`c184fb1`](c184fb1),
[`55f1e99`](55f1e99)]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Minor Changes

- [#535](#535)
[`c184fb1`](c184fb1)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Add CeloToken and
LockedCelo aliases for deprecated GoldToken and LockedCelo Contracts
enum

- [#533](#533)
[`549450f`](549450f)
Thanks [@soloseng](https://github.com/soloseng)! - added support for
epochManager processGroups function to contractkit && celocli

### Patch Changes

- [#553](#553)
[`78f9831`](78f9831)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Use production
release of @celo/abis

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- Updated dependencies
\[[`f11a069`](f11a069)]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- Updated dependencies
\[[`f11a069`](f11a069)]:
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- Updated dependencies
\[[`f11a069`](f11a069)]:
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- Updated dependencies
\[[`78f9831`](78f9831),
[`f11a069`](f11a069),
[`c184fb1`](c184fb1),
[`549450f`](549450f)]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#553](#553)
[`78f9831`](78f9831)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Use production
release of @celo/abis

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- [#535](#535)
[`c184fb1`](c184fb1)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Ensure CeloToken
and LockedCelo can be used as aliases for GoldToken and LockedGold

- [#542](#542)
[`55f1e99`](55f1e99)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - When building
proposals if there is a failure show more informational error messages

- Updated dependencies
\[[`78f9831`](78f9831),
[`f11a069`](f11a069),
[`c184fb1`](c184fb1),
[`549450f`](549450f)]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- Updated dependencies
\[[`f11a069`](f11a069)]:
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- Updated dependencies
\[[`f11a069`](f11a069)]:
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- Updated dependencies
\[[`f11a069`](f11a069)]:
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- Updated dependencies
\[[`f11a069`](f11a069)]:
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- Updated dependencies
\[[`f11a069`](f11a069)]:
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- Updated dependencies
\[[`f11a069`](f11a069)]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- Updated dependencies
\[[`f11a069`](f11a069)]:
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- Updated dependencies
\[[`f11a069`](f11a069)]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- Updated dependencies
\[[`f11a069`](f11a069)]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- Updated dependencies
\[[`f11a069`](f11a069)]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- [#544](#544)
[`170e91c`](170e91c)
Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Allow
users to use other apps than ethereum or celo, namely "eth recovery" in
order to recovery funds or signTypedData which isnt supported by celo
but would require the correct derivationPath

- Updated dependencies
\[[`f11a069`](f11a069)]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- Updated dependencies
\[[`f11a069`](f11a069)]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- Updated dependencies
\[[`f11a069`](f11a069)]:
    -   @celo/[email protected]
    -   @celo/[email protected]
    -   @celo/[email protected]

## @celo/[email protected]

### Patch Changes

- [#558](#558)
[`f11a069`](f11a069)
Thanks [@aaronmgdr](https://github.com/aaronmgdr)! - Fix incorrect repo
link in package.json

- [#544](#544)
[`170e91c`](170e91c)
Thanks [@nicolasbrugneaux](https://github.com/nicolasbrugneaux)! - Allow
users to use other apps than ethereum or celo, namely eth recovery in
order to recovery funds or signTypedData which isnt supported by celo
but would require the correct derivationPath (which, in turn, isn't
supported by ethereum)

- Updated dependencies
\[[`f11a069`](f11a069)]:
    -   @celo/[email protected]


<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating various package versions and fixing an
incorrect repository link in the `package.json` files across multiple
packages in the Celo SDK.

### Detailed summary
- Deleted multiple `.changeset` files.
- Updated versions in `package.json` files for several packages:
  - `@celo/base` to `7.0.2`
  - `@celo/network-utils` to `5.0.8`
  - `@celo/utils` to `8.0.2`
  - Other packages also updated with their respective new versions.
- Added changelog entries for new versions, including fixes and updates.
- Fixed incorrect repository link in multiple `package.json` files.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your
question}`

<!-- end pr-codex -->

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants