Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade nextjs and add config assertions #193

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Conversation

nicolasbrugneaux
Copy link
Contributor

WIP:

  • nextjs upgrade
  • nextjs breaking changes handled
  • .env assertions
  • server side sourcemaps for better debugging

@nicolasbrugneaux nicolasbrugneaux requested a review from a team as a code owner March 17, 2025 14:23
Copy link

vercel bot commented Mar 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
celo-mondo ✅ Ready (Inspect) Visit Preview Mar 17, 2025 2:43pm

Copy link

socket-security bot commented Mar 17, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@emnapi/[email protected] environment, eval 0 438 kB toyobayashi
npm/@img/[email protected] None 0 274 kB lovell
npm/@img/[email protected] None 0 258 kB lovell
npm/@img/[email protected] None 0 15.6 MB lovell
npm/@img/[email protected] None 0 18.2 MB lovell
npm/@img/[email protected] None 0 13.3 MB lovell
npm/@img/[email protected] None 0 16.2 MB lovell
npm/@img/[email protected] None 0 15.3 MB lovell
npm/@img/[email protected] None 0 16.2 MB lovell
npm/@img/[email protected] None 0 16 MB lovell
npm/@img/[email protected] None 0 16.5 MB lovell
npm/@img/[email protected] None 0 241 kB lovell
npm/@img/[email protected] None 0 273 kB lovell
npm/@img/[email protected] None 0 309 kB lovell
npm/@img/[email protected] None 0 281 kB lovell
npm/@img/[email protected] None 0 342 kB lovell
npm/@img/[email protected] None 0 297 kB lovell
npm/@img/[email protected] None 0 10.9 MB lovell
npm/@img/[email protected] None 0 18.9 MB lovell
npm/@img/[email protected] None 0 19.8 MB lovell
npm/@next/[email protected]15.2.2 None 0 0 B
npm/@next/[email protected]15.2.2 None +1 180 kB matt.straka, rauchg, timer, ...2 more
npm/@next/[email protected]15.2.2 None 0 131 MB matt.straka, rauchg, timer, ...2 more
npm/@next/[email protected]15.2.2 None 0 126 MB matt.straka, rauchg, timer, ...2 more
npm/@next/[email protected]15.2.2 None 0 0 B
npm/@next/[email protected]15.2.2 None 0 132 MB matt.straka, rauchg, timer, ...2 more
npm/@next/[email protected]15.2.2 None 0 144 MB matt.straka, rauchg, timer, ...2 more
npm/@next/[email protected]15.2.2 None 0 144 MB matt.straka, rauchg, timer, ...2 more
npm/@next/[email protected]15.2.2 None 0 117 MB vercel-release-bot
npm/@next/[email protected]15.2.2 None 0 148 MB matt.straka, rauchg, timer, ...2 more
npm/@rtsao/[email protected] None 0 3.61 kB rtsao
npm/@rushstack/[email protected]1.11.0 None 0 255 kB octogonz, odspnpm, rushstack-admin
npm/@swc/[email protected]0.5.15 None +1 325 kB kdy1
npm/@vercel/[email protected] None 0 86.9 kB vercel-release-bot
npm/[email protected] None 0 12 kB ljharb
npm/[email protected]3.1.8 None +2 64 kB ljharb
npm/[email protected] None +1 42 kB ljharb
npm/[email protected]1.2.6 None 0 0 B
npm/[email protected]1.1.4 None 0 20.9 kB ljharb
npm/[email protected] None +1 37.8 kB ljharb
npm/[email protected]4.10.3 None 0 2.79 MB dqlabs, dylanb, npmdeque, ...1 more
npm/[email protected]4.1.0 None 0 111 kB ljharb
npm/[email protected] None 0 10.1 kB qix
npm/[email protected] None 0 16.8 kB qix
npm/[email protected] None 0 11.3 kB ljharb
npm/[email protected] None 0 11.4 kB ljharb
npm/[email protected] None 0 11.1 kB ljharb
npm/[email protected] filesystem, shell 0 23.6 kB lovell
npm/[email protected]1.2.1 None +1 219 kB ljharb
npm/[email protected] None 0 44.5 kB ljharb
npm/[email protected]15.2.2 None 0 0 B
npm/[email protected]2.31.0 environment +4 1.62 MB ljharb
npm/[email protected]6.10.2 None +1 929 kB ljharb
npm/[email protected]5.2.0 None 0 278 kB acdlite, brianvaughn, eps1lon, ...4 more
npm/[email protected]7.37.4 Transitive: environment +2 1.1 MB ljharb, yannickcr
npm/[email protected] None 0 27.1 kB ljharb
npm/[email protected] None 0 17.2 kB ljharb
npm/[email protected] None 0 23.7 kB ljharb
npm/[email protected] None 0 14.5 kB ljharb
npm/[email protected] None 0 23 kB ljharb
npm/[email protected] None 0 54.7 kB qix
npm/[email protected] None 0 17.9 kB ljharb
npm/[email protected] None 0 26.5 kB ljharb
npm/[email protected] None +1 35.4 kB ljharb
npm/[email protected]1.1.1 None 0 17.2 kB ljharb
npm/[email protected]2.0.3 None 0 20.4 kB ljharb
npm/[email protected] None 0 25.2 kB ljharb
npm/[email protected] None 0 35.7 kB ljharb
npm/[email protected]2.0.3 None 0 19.7 kB ljharb
npm/[email protected] None 0 17.1 kB ljharb
npm/[email protected] None 0 27 kB ljharb
npm/[email protected]2.0.2 None 0 20.6 kB ljharb
npm/[email protected] None 0 15.9 kB ljharb
npm/[email protected]2.0.4 None 0 19.8 kB ljharb
npm/[email protected]1.1.5 None +1 43.4 kB ljharb
npm/[email protected]15.2.2 None 0 111 MB rauchg, timneutkens, vercel-release-bot
npm/[email protected] None 0 103 kB ljharb
npm/[email protected]1.1.9 None 0 33.7 kB ljharb
npm/[email protected]2.0.8 None 0 16.3 kB ljharb
npm/[email protected]1.0.3 None 0 14.6 kB ljharb
npm/[email protected]1.2.1 None +1 32.7 kB ljharb
npm/[email protected] None 0 9.8 kB ljharb
npm/[email protected] None 0 9.7 kB ljharb
npm/[email protected] None 0 44.3 kB ljharb
npm/[email protected] None +1 21 kB ljharb
npm/[email protected] None 0 8.5 kB ljharb
npm/[email protected]1.1.0 None 0 11.9 kB ljharb
npm/[email protected]2.0.2 None 0 16.7 kB ljharb
npm/[email protected] None 0 9.3 kB ljharb
npm/[email protected] environment +1 600 kB lovell
npm/[email protected] None 0 14.7 kB ljharb
npm/[email protected] None 0 13.3 kB ljharb
npm/[email protected] None 0 14.7 kB ljharb
npm/[email protected]1.1.0 None 0 21.5 kB ljharb
npm/[email protected] None 0 3.6 kB qix
npm/[email protected] None 0 16.2 kB nicolo-ribaudo
npm/[email protected]4.0.12 None 0 39.8 kB ljharb
npm/[email protected] None +1 2.4 MB nicolo-ribaudo
npm/[email protected] None 0 35.2 kB ljharb
npm/[email protected]1.0.9 None 0 23.6 kB ljharb
npm/[email protected] None 0 22.9 kB ljharb
npm/[email protected]5.1.6 None 0 1.03 MB vercel-release-bot
npm/[email protected] None 0 12.2 kB ljharb
npm/[email protected] None 0 18.4 kB ljharb
npm/[email protected] None 0 19.8 kB ljharb
npm/[email protected] None +1 47.6 kB ljharb
npm/[email protected] None 0 18.5 kB ljharb
npm/[email protected] None 0 19.3 kB ljharb
npm/[email protected]1.2.1 None +1 54.2 kB ljharb
npm/[email protected]1.0.2 None 0 20.1 kB ljharb

🚮 Removed packages: npm/@next/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Mar 17, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@nicolasbrugneaux
Copy link
Contributor Author

@SocketSecurity ignore npm/[email protected]

@aaronmgdr
Copy link
Member

I like the direction this goes with rendering more stuff on server. in future maybe we take it even further.

I worry that it seems like there is a delay now from when i click a proposal in the list and when it starts navigating to it but maybe im imagining it?

@nicolasbrugneaux
Copy link
Contributor Author

I like the direction this goes with rendering more stuff on server. in future maybe we take it even further.

I worry that it seems like there is a delay now from when i click a proposal in the list and when it starts navigating to it but maybe im imagining it?

I'm not sure what you're referring to, I merely refactored according to breaking changes (nextjs 14->15), no behaviour was changed.

If you're referring to the use server directives, they were implicit before (as your inline comments indicated not to use client ever) so I made them explicit for the compiler to be stricter

@aaronmgdr
Copy link
Member

I like the direction this goes with rendering more stuff on server. in future maybe we take it even further.
I worry that it seems like there is a delay now from when i click a proposal in the list and when it starts navigating to it but maybe im imagining it?

I'm not sure what you're referring to, I merely refactored according to breaking changes (nextjs 14->15), no behaviour was changed.

If you're referring to the use server directives, they were implicit before (as your inline comments indicated not to use client ever) so I made them explicit for the compiler to be stricter

sorry my mistake!

@aaronmgdr aaronmgdr merged commit 268c6f9 into main Mar 21, 2025
9 checks passed
@aaronmgdr aaronmgdr deleted the chore/mondo-upgrades branch March 21, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants