Fix 1-element vec ambiguities #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fknorr
approved these changes
Jan 28, 2025
Comment on lines
+238
to
+240
| template<typename T> | ||
| swizzled_vec &operator=(const T &rhs) | ||
| requires(allow_assign && std::convertible_to<T, value_type>) |
There was a problem hiding this comment.
Suggested change
| template<typename T> | |
| swizzled_vec &operator=(const T &rhs) | |
| requires(allow_assign && std::convertible_to<T, value_type>) | |
| template<std::convertible_to<value_type> T> | |
| swizzled_vec &operator=(const T &rhs) | |
| requires(allow_assign) |
Comment on lines
+545
to
+548
| template<typename T> | ||
| vec &operator=(const T &rhs) | ||
| requires(std::convertible_to<T, DataT>) | ||
| { |
There was a problem hiding this comment.
Suggested change
| template<typename T> | |
| vec &operator=(const T &rhs) | |
| requires(std::convertible_to<T, DataT>) | |
| { | |
| template<std::convertible_to<DataT> T> | |
| vec &operator=(const T &rhs) | |
| { |
Comment on lines
+763
to
+765
| template<typename T> \ | ||
| friend vec operator op(const vec &lhs, const T &rhs) \ | ||
| requires(enable_if && std::convertible_to<T, DataT>) \ |
There was a problem hiding this comment.
Suggested change
| template<typename T> \ | |
| friend vec operator op(const vec &lhs, const T &rhs) \ | |
| requires(enable_if && std::convertible_to<T, DataT>) \ | |
| template<std::convertible_to<DataT> T> \ | |
| friend vec operator op(const vec &lhs, const T &rhs) \ | |
| requires(enable_if) \ |
(same for overloads below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third part of a series of four pull requests addressing some SYCL clarifications for
sycl::vec.This pull request implements the behavior specified in KhronosGroup/SYCL-Docs#670 (comment), which resolves ambiguities for 1-element
sycl::vec.