Add async benchmark for logback-logstash-encoder#4
Open
brenuart wants to merge 2 commits intoceki:masterfrom
Open
Add async benchmark for logback-logstash-encoder#4brenuart wants to merge 2 commits intoceki:masterfrom
brenuart wants to merge 2 commits intoceki:masterfrom
Conversation
Add a benchmark based on async support provided by logback-logstash-encoder.
The LLE-FILE appender is not started when declared "inside" the LLE appender.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logback-logstash-encoder (LLE) project comes with an AsyncDisruptorAppender wrapper that can be used to log asynchronously to an otherwise synchronous appender.
This PR adds a benchmark in the AsyncWithFileAppenderBenchmark test suite to evaluate the LLE async solution alongside the other ones.
A few points about the integration:
logbackLleFilebenchmark logs directly to theLLEcategory to target the LLE appender.Thanks for considering adding this benchmark to your suite.