Script to create entries from the CI. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the CLI. Usage: python -m ceda_status_validator.editor add-entry
danny-lloyd
reviewed
Jan 14, 2025
| "--status", | ||
| prompt=True, | ||
| type=click.Choice(list(model.Status.__members__.keys())), | ||
| default=model.Status.DOWN._name_, |
There was a problem hiding this comment.
Is there a reason to use the Enum's ._name_ rather than using .name?
There was a problem hiding this comment.
Looks like they are the same. No idea why I did that. Maybe try it with .name and see if it still works?
danny-lloyd
reviewed
Jan 14, 2025
Comment on lines
+48
to
+49
| "%Y-%m-%dT%H:%M:%S", | ||
| "%Y-%m-%d %H:%M:%S", |
There was a problem hiding this comment.
Do we want to accept times with seconds if the model is going to strip them out to this format anyway: "%Y-%m-%dT%H:%M"?
There was a problem hiding this comment.
No preference, don't think it matters either way, happy to remove.
amanning9
force-pushed
the
create-script
branch
from
655d77f to
827dc90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage: python -m ceda_status_validator.editor add-entry