Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable NewRelic package reporting to monitor perf improvements #2361

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

jimleroyer
Copy link
Member

@jimleroyer jimleroyer commented Nov 15, 2024

Summary | Résumé

In version 9.1.0 of NewRelic Python agent, there were improvements done on the package reporting. I want to test it out in staging to see if we can keep this feature or should just disable it.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

Trigger restart of kubernetes API deployment and monitor timing + potential loop crash. At this time, this is the config for probes that work for the API and with New Relic reporting disabled:

        livenessProbe:
          failureThreshold: 3
          httpGet:
            path: /_status?simple=true
            port: 6011
            scheme: HTTP
          initialDelaySeconds: 30
          periodSeconds: 3
          successThreshold: 1
          timeoutSeconds: 1
        name: api
        ports:
        - containerPort: 6011
          protocol: TCP
        readinessProbe:
          failureThreshold: 10
          httpGet:
            path: /_status?simple=true
            port: 6011
            scheme: HTTP
          initialDelaySeconds: 5
          periodSeconds: 3
          successThreshold: 3
          timeoutSeconds: 1
        resources:
          limits:
            cpu: 1200m
            memory: 900Mi
          requests:
            cpu: 200m
            memory: 700Mi
        startupProbe:
          failureThreshold: 20
          httpGet:
            path: /_status?simple=true
            port: 6011
            scheme: HTTP
          initialDelaySeconds: 20
          periodSeconds: 3
          successThreshold: 1
          timeoutSeconds: 1

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@jimleroyer jimleroyer self-assigned this Nov 15, 2024
Copy link
Contributor

@P0NDER0SA P0NDER0SA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sastels sastels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪

@jimleroyer jimleroyer merged commit 56da4f9 into main Nov 15, 2024
5 checks passed
@jimleroyer jimleroyer deleted the feat/newrelic-enable-package-reporting branch November 15, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants