Allow sns and pinpoint to send internationally (#2197)

migrations/versions/0453_set_supports_international.py

@@ -0,0 +1,25 @@
+"""
+
+Revision ID: 0453_set_supports_international
+Revises: 0452_set_pgaudit_config
+Create Date: 2024-06-20 14:36:03.038934
+
+"""
+from alembic import op
+
+revision = "0453_set_supports_international"
+down_revision = "0452_set_pgaudit_config"
+
+
+def upgrade():
+ op.execute("UPDATE provider_details SET supports_international=True WHERE identifier='sns'")
+ op.execute("UPDATE provider_details SET supports_international=True WHERE identifier='pinpoint'")
+ op.execute("UPDATE provider_details_history SET supports_international=True WHERE identifier='sns'")
+ op.execute("UPDATE provider_details_history SET supports_international=True WHERE identifier='pinpoint'")
+
+
+def downgrade():
+ op.execute("UPDATE provider_details SET supports_international=False WHERE identifier='sns'")
+ op.execute("UPDATE provider_details SET supports_international=False WHERE identifier='pinpoint'")
+ op.execute("UPDATE provider_details_history SET supports_international=False WHERE identifier='sns'")
+ op.execute("UPDATE provider_details_history SET supports_international=False WHERE identifier='pinpoint'")

tests/app/dao/test_provider_details_dao.py

@@ -29,7 +29,7 @@ def test_can_get_sms_non_international_providers(restore_provider_details):
 
 def test_can_get_sms_international_providers(restore_provider_details):
  sms_providers = get_provider_details_by_notification_type("sms", True)
- assert len(sms_providers) == 1
+ assert len(sms_providers) == 3
  assert all("sms" == prov.notification_type for prov in sms_providers)
  assert all(prov.supports_international for prov in sms_providers)
 
@@ -291,7 +291,7 @@ def test_dao_get_provider_stats(notify_db_session):
 
  assert result[1].identifier == "sns"
  assert result[1].display_name == "AWS SNS"
- assert result[1].supports_international is False
+ assert result[1].supports_international is True
  assert result[1].active is True
  assert result[1].current_month_billable_sms == 4
 
@@ -312,6 +312,6 @@ def test_dao_get_provider_stats(notify_db_session):
 
  assert result[5].identifier == "pinpoint"
  assert result[5].notification_type == "sms"
- assert result[5].supports_international is False
+ assert result[5].supports_international is True
  assert result[5].active is True
  assert result[5].current_month_billable_sms == 0