Skip to content

[CDAP-20993] Periodic refresh implementation of source control metadata for SCM sync status #14777

[CDAP-20993] Periodic refresh implementation of source control metadata for SCM sync status

[CDAP-20993] Periodic refresh implementation of source control metadata for SCM sync status #14777

Triggered via pull request May 6, 2024 19:55
Status Success
Total duration 9s
Artifacts

trigger.yml

on: pull_request
trigger
0s
trigger
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 37 warnings
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/services/ApplicationLifecycleService.java#L454
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '425'.
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/DefaultStore.java#L571
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '557'.
RightCurlySame: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/DefaultStore.java#L632
'}' at column 7 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).
com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/DefaultStore.java#L633
WhitespaceAround: 'else' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/DefaultStore.java#L634
WhitespaceAround: 'if' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
RightCurlySame: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/DefaultStore.java#L658
'}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).
com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/DefaultStore.java#L659
WhitespaceAround: 'else' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/store/DefaultStore.java#L660
WhitespaceAround: 'if' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3)
com.puppycrawl.tools.checkstyle.checks.coding.OverloadMethodsDeclarationOrderCheck: cdap-app-fabric/src/main/java/io/cdap/cdap/app/store/Store.java#L355
All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '322'.
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L362
Distance between variable 'request' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L445
Abbreviation in name 'testDeployVersionedAndNonVersionedAppLCMFlagEnabled' must contain no more than '1' consecutive capital letters.
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L556
Abbreviation in name 'testListAndGetLCMFlagEnabledInstanceUpgradeScenario' must contain no more than '1' consecutive capital letters.
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L652
Abbreviation in name 'testListAndGetForPaginatedAPI' must contain no more than '1' consecutive capital letters.
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L693
Abbreviation in name 'testListAndGetForPaginatedAPIWithEmptyLastPage' must contain no more than '1' consecutive capital letters.
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L734
Abbreviation in name 'testListAndGetForPaginatedAPIWithFiltering' must contain no more than '1' consecutive capital letters.
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L780
Abbreviation in name 'testListAndGetForPaginatedAPIWithNameFilterType' must contain no more than '1' consecutive capital letters.
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L822
Abbreviation in name 'testListAndGetForPaginatedAPIWithLatestOnlyLCMFlagEnabled' must contain no more than '1' consecutive capital letters.
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L890
Abbreviation in name 'testListAndGetLCMFlagEnabledForVersionHistory' must contain no more than '1' consecutive capital letters.
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L1035
Abbreviation in name 'testListAndGetLCMFlagEnabled' must contain no more than '1' consecutive capital letters.
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L1159
Distance between variable 'appReference' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L1322
Distance between variable 'applicationId' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L1438
Abbreviation in name 'testDeleteVersionedAppLCMEnabled' must contain no more than '1' consecutive capital letters.
com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck: cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/NamespaceSourceControlMetadataRefreshServiceTest.java#L68
Wrong lexicographical order for 'io.cdap.cdap.spi.data.transaction.TransactionRunner' import. Should be before 'org.mockito.Mockito'.