[CDAP-21148] check pipeline size on change and before save / deploy #1296
Conversation
GnsP
requested review from
njbriggs,
radhikav1,
itsankit-google and
sidhdirenge
| @@ -1456,6 +1457,16 @@ class HydratorPlusPlusTopPanelCtrl { | |||
| } | |||
|
|
|||
| let uploadedFile = files[0]; | |||
|
|
|||
| const MB = 1024 * 1024; // Bytes | |||
| if (files[0].size > 2 * MB) { | |||
There was a problem hiding this comment.
can we make it configurable from CConf?
There was a problem hiding this comment.
Yeah, we can. Would require backend changes also. We would need the value inside CDAP_CONFIG.
There was a problem hiding this comment.
For now, we are going to to keep this size limit as a static value in the UI.
There was a problem hiding this comment.
Let's make it configurable from cConf if possible?
We are planning to introduce chunking soon, so UI check can become a blocker during testing
There was a problem hiding this comment.
Yeah, we can. Would require backend changes also. We would need the value inside CDAP_CONFIG.
I don't think we need the changes in backend for this.
There was a problem hiding this comment.
yes, we do. Here is the corresponding backend PR: cdapio/cdap#15921
GnsP
changed the title
GnsP
force-pushed
the
add-pipeline-size-check
branch
from
45e6fd3 to
5b2bc33
Compare
GnsP
force-pushed
the
add-pipeline-size-check
branch
from
dadb725 to
5267dd1
Compare
Check pipeline size is less than 2MB
Description
Summary of changes
PR Type
Links
Jira: CDAP-21148
Test Plan
Screenshots
The pipeline in this screenshot has a large description
