Skip to content

Upgrade node version as CDAP UI builds are failing with incompatible node version error #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itsankit-google merged 1 commit into from
Dec 7, 2024
Merged

Upgrade node version as CDAP UI builds are failing with incompatible node version error #1265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@ jobs:
with:
submodules: recursive

# installing node 16.16
- name: Use Node.js 16.16
# installing node 22.12
- name: Use Node.js 22.12
uses: actions/[email protected]
with:
node-version: 16.16
node-version: 22.12

- uses: actions/[email protected]
with:
Expand Down
2 changes: 1 addition & 1 deletion app/cdap/services/DataFormatter/__tests__/DataFormatter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ describe('DataFormatter', () => {
minute: 'numeric',
second: 'numeric',
})
).toBe('Thursday, September 16, 2021, 10:33:30 AM');
).toBe('Thursday, September 16, 2021 at 10:33:30 AM');
});
});
});
28 changes: 14 additions & 14 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,24 @@
"license": "Apache-2.0",
"scripts": {
"dev": "concurrently \"yarn start\" \"gulp watch\" \"yarn cdap-dev-build-w\" \"yarn build-dev-common-w\"",
"start": "yarn run build-server && NODE_ENV=development node ./packaged/server_dist/index.js",
"cdap-prod-build": "NODE_ENV=production parallel-webpack",
"cdap-dev-build": "NODE_ENV=development parallel-webpack --config=webpack.config.js -d",
"cdap-dev-build-w": "NODE_ENV=development parallel-webpack --watch -d ",
"reload-dev-w": "NODE_ENV=reload node --max-old-space-size=8192 ./node_modules/.bin/webpack-dev-server --mode development --progress --config=./webpack.config.cdap.dev.js",
"hmr-dev-w": "NODE_ENV=hmr node --max-old-space-size=8192 ./node_modules/.bin/webpack-dev-server --mode development --progress --config=./webpack.config.cdap.dev.js",
"cdap-full-build": "run-p cdap-prod-build distribute",
"cdap-full-build-more-memory": "NODE_OPTIONS=\"--max_old_space_size=8192\" run-p cdap-prod-build distribute",
"cdap-non-optimized-full-build": "NODE_ENV=non-optimized-production webpack --config=webpack.config.js",
"start": "NODE_OPTIONS=\"--openssl-legacy-provider\" yarn run build-server && NODE_ENV=development node ./packaged/server_dist/index.js",
"cdap-prod-build": "NODE_OPTIONS=\"--openssl-legacy-provider\" NODE_ENV=production parallel-webpack",
"cdap-dev-build": "NODE_OPTIONS=\"--openssl-legacy-provider\" NODE_ENV=development parallel-webpack --config=webpack.config.js -d",
"cdap-dev-build-w": "NODE_OPTIONS=\"--openssl-legacy-provider\" NODE_ENV=development parallel-webpack --watch -d ",
"reload-dev-w": "NODE_OPTIONS=\"--openssl-legacy-provider\" NODE_ENV=reload node --max-old-space-size=8192 ./node_modules/.bin/webpack-dev-server --mode development --progress --config=./webpack.config.cdap.dev.js",
"hmr-dev-w": "NODE_OPTIONS=\"--openssl-legacy-provider\" NODE_ENV=hmr node --max-old-space-size=8192 ./node_modules/.bin/webpack-dev-server --mode development --progress --config=./webpack.config.cdap.dev.js",
"cdap-full-build": "NODE_OPTIONS=\"--openssl-legacy-provider\" run-p cdap-prod-build distribute",
"cdap-full-build-more-memory": "NODE_OPTIONS=\"--openssl-legacy-provider --max_old_space_size=8192\" run-p cdap-prod-build distribute",
"cdap-non-optimized-full-build": "NODE_OPTIONS=\"--openssl-legacy-provider\" NODE_ENV=non-optimized-production webpack --config=webpack.config.js",
"clean-node-modules": "modclean -P -r --patterns=\"default:safe\" --additional-patterns=\"*.xls?x,*.ppt?x,*.rtf,*.png,*.jpg,*.jpeg,*.txt\" --ignore=\"validate-npm-license,readme*\"",
"distribute": "node ./node_modules/gulp/bin/gulp.js distribute",
"build": "node ./node_modules/gulp/bin/gulp.js build",
"build-w": "node ./node_modules/gulp/bin/gulp.js watch",
"build-prod-common": "NODE_ENV=production parallel-webpack --config=webpack.config.common.js",
"build-dev-common": "NODE_ENV=development parallel-webpack --config=webpack.config.common.js",
"build-dev-common-w": "NODE_ENV=development parallel-webpack --config=webpack.config.common.js -d --watch",
"build-prod-dlls": "NODE_ENV=production parallel-webpack --config=webpack.config.dlls.js",
"build-dev-dlls": "NODE_ENV=development parallel-webpack --config=webpack.config.dlls.js",
"build-prod-common": "NODE_OPTIONS=\"--openssl-legacy-provider\" NODE_ENV=production parallel-webpack --config=webpack.config.common.js",
"build-dev-common": "NODE_OPTIONS=\"--openssl-legacy-provider\" NODE_ENV=development parallel-webpack --config=webpack.config.common.js",
"build-dev-common-w": "NODE_OPTIONS=\"--openssl-legacy-provider\" NODE_ENV=development parallel-webpack --config=webpack.config.common.js -d --watch",
"build-prod-dlls": "NODE_OPTIONS=\"--openssl-legacy-provider\" NODE_ENV=production parallel-webpack --config=webpack.config.dlls.js",
"build-dev-dlls": "NODE_OPTIONS=\"--openssl-legacy-provider\" NODE_ENV=development parallel-webpack --config=webpack.config.dlls.js",
"build-server": "webpack --config=webpack.config.server.js",
"jest": "jest --coverage",
"jest-w": "jest --watch",
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@
<goal>install-node-and-yarn</goal>
</goals>
<configuration>
<nodeVersion>v16.20.0</nodeVersion>
<nodeVersion>v22.12.0</nodeVersion>
<yarnVersion>v1.22.19</yarnVersion>
</configuration>
</execution>
Expand Down Expand Up @@ -370,7 +370,7 @@
<goal>install-node-and-yarn</goal>
</goals>
<configuration>
<nodeVersion>v16.16.0</nodeVersion>
<nodeVersion>v22.12.0</nodeVersion>
<yarnVersion>v1.7.0</yarnVersion>
</configuration>
</execution>
Expand Down
Loading