[CDAP-18568] Support CustomVolumes and CustomVolumeMounts for CDAP System Services #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dli357
force-pushed
the
feature/CDAP-18568-Custom-Volumes
branch
2 times, most recently
from
e036adc to
20ea947
Compare
|
Checked that this change satisfying the next requirements (which caused the creation of #72):
|
dli357
force-pushed
the
feature/CDAP-18568-Custom-Volumes
branch
from
20ea947 to
fad9f18
Compare
wyzhang
reviewed
Jan 7, 2022
dli357
force-pushed
the
feature/CDAP-18568-Custom-Volumes
branch
3 times, most recently
from
0f4251e to
fdf0de4
Compare
wyzhang
approved these changes
Jan 18, 2022
dli357
force-pushed
the
feature/CDAP-18568-Custom-Volumes
branch
from
fdf0de4 to
4d1075c
Compare
…stem Services
[CDAP-18568] Switch name to AdditionalVolumes and AdditionalVolumeMounts and added clarifying comments
dli357
force-pushed
the
feature/CDAP-18568-Custom-Volumes
branch
from
4d1075c to
f71a513
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds the ability for a user to directly specify custom k8s volumes and volume mounts in the CDAP CR.
Custom volumes and volume mounts specified in the upper-level CR will be applied to all services, and custom volumes and volume mounts specified in the particular service will only be applied to that service. Custom volume mounts for a service are applied to all containers and init containers for that service.