-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚨 Run clang-tidy on MLIR subproject, switch to LLVM@20
, and update to CMake >= 3.24
#879
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (84.0%) is below the target coverage (90.0%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
=======================================
+ Coverage 92.3% 92.5% +0.2%
=======================================
Files 145 145
Lines 13850 13841 -9
Branches 2107 2107
=======================================
+ Hits 12789 12815 +26
+ Misses 1061 1026 -35
🚀 New features to boost your workflow:
|
1ed6a13
to
5204eaa
Compare
5204eaa
to
2db583b
Compare
@flowerthrower @ystade just venting my frustration here. Of course the LLVM set up would be making problems with clang-tidy.. it's not like that is actually part of the same monorepository.. |
LLVM@20
, and update to CMake >= 3.24
…VM@20 Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
the latest Ubuntu LTS version 24.04 ships with 3.28 so we should be good. Signed-off-by: burgholzer <[email protected]>
…CoreIR library privately linking to the `project_options` does not propagte the feature requirement to the interface properties of the linked target, which is undesired. Everyone linking against our libraries will almost surely have to have C++ 17 support. Signed-off-by: burgholzer <[email protected]>
this was revealed as part of enabling `CMAKE_VERIFY_INTERFACE_HEADER_SETS` Signed-off-by: burgholzer <[email protected]>
also removes the legacy `QFRException` class and moves some methods from the `ir/Definitions` file to a more suitable place. Signed-off-by: burgholzer <[email protected]>
… enable interface header verification Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
b5d56e5
to
4642a92
Compare
Description
This pull request enables running
clang-tidy
for the MLIR subproject and updates the project to use LLVM version 20. This enhances code quality checks and aligns the project with the latest LLVM updates. It is also the same version currently shipped with CLion.In addition, this PR raises the minimum supported CMake version to 3.24, which brings in several improvements:
Checklist: