Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fetchBorrowRate #22279

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Remove fetchBorrowRate #22279

wants to merge 2 commits into from
+68 −23

Conversation

samgermain
Copy link
Member

  • removes fetchBorrowRate, fetchBorrowRates, fetchBorrowRatesPerSymbol
  • replaces fetchBorrowRate(s) with fetchCrossBorrowRate(s)/fetchIsolatedBorrowRate(s) in transpiling and base methods
  • adds test files for fetchCrossBorrowRate(s) and fetchIsolatedBorrowRate(s)

@samgermain samgermain changed the title Remove fetch borrow rate Remove fetchBorrowRate Apr 25, 2024
@samgermain samgermain marked this pull request as draft April 25, 2024 12:40
@samgermain
Copy link
Member Author

samgermain commented Apr 27, 2024 •
edited

This error is happening

/home/travis/build/ccxt/ccxt/cs/tests/Generated/Exchange/test.fetchIsolatedBorrowRates.cs(19,13): error CS0103: The name 'testIsolatedBorrowRate' does not exist in the current context [/home/travis/build/ccxt/ccxt/cs/tests/tests.csproj]

    132 Warning(s)

    1 Error(s)

Why is test.fetchIsolatedBorrowRates being transpiled, but apparently testIsolatedBorrowRate is not

@samgermain
Copy link
Member Author

AppVeyor failing for no reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroitor kroitor Awaiting requested review from kroitor kroitor is a code owner

@frosty00 frosty00 Awaiting requested review from frosty00 frosty00 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@samgermain