feat(base) - safeIntegerOmitZero #22244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmiei
reviewed
Apr 23, 2024
kroitor
pushed a commit
that referenced
this pull request
May 9, 2024
* feat(base) - safeIntegerOmitZero * fix(latoken) - zero ts in tickers * minor bitget * parseint * Update Exchange.ts * fix linting --------- Co-authored-by: carlosmiei <[email protected]> [ci skip]
DelAnt
pushed a commit
to DelAnt/ccxt
that referenced
this pull request
May 10, 2024
* feat(base) - safeIntegerOmitZero * fix(latoken) - zero ts in tickers * minor bitget * parseint * Update Exchange.ts * fix linting --------- Co-authored-by: carlosmiei <[email protected]>
DelAnt
pushed a commit
to DelAnt/ccxt
that referenced
this pull request
May 10, 2024
* feat(base) - safeIntegerOmitZero * fix(latoken) - zero ts in tickers * minor bitget * parseint * Update Exchange.ts * fix linting --------- Co-authored-by: carlosmiei <[email protected]> [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: https://app.travis-ci.com/github/ccxt/ccxt/builds/270079297#L5259
also, for simple purposes we had 5-line hardcoded repeated code to parse zero timestamps, and moved into base to simplify the process, as this method would be need in multiple exchanges too