feat(kucoinfutures): add watchPositions and upgrade ast-transpiler to v0.0.46 #22169

pcriadoperez · 2024-04-16T08:20:18Z

Include ast-transpiler upgrade that fixes delete in csharp

…res-watchpositions

carlosmiei · 2024-04-18T09:57:08Z

 p kucoinfutures watchPositions
Python v3.11.7
CCXT v4.2.99
kucoinfutures.watchPositions()
[]
Traceback (most recent call last):
  File "/Users/cjg/Git/ccxt9/ccxt/examples/py/cli.py", line 249, in <module>
    asyncio.run(main())
  File "/opt/homebrew/Cellar/[email protected]/3.11.7_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/runners.py", line 190, in run
    return runner.run(main)
           ^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.7_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.7_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 653, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/Users/cjg/Git/ccxt9/ccxt/examples/py/cli.py", line 228, in main
    result = await result
             ^^^^^^^^^^^^
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/pro/kucoinfutures.py", line 386, in watch_positions
    newPosition = await self.subscribe(url, messageHash, topic, None, self.extend(request, params))
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/pro/kucoinfutures.py", line 150, in subscribe
    return await self.watch(url, messageHash, message, subscriptionHash, subscription)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/async_support/base/ws/fast_client.py", line 26, in handler
    self.handle_message(message)
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/async_support/base/ws/aiohttp_client.py", line 34, in handle_message
    self.handle_text_or_binary_message(message.data)
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/async_support/base/ws/aiohttp_client.py", line 29, in handle_text_or_binary_message
    self.on_message_callback(self, decoded)
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/pro/kucoinfutures.py", line 1049, in handle_message
    method(client, message)
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/pro/kucoinfutures.py", line 997, in handle_subject
    method(client, message)
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/pro/kucoinfutures.py", line 519, in handle_position
    position = self.extend(currentPosition, newPosition)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/base/exchange.py", line 963, in extend
    result.update(arg)
TypeError: 'NoneType' object is not iterable
kucoinfutures requires to release all resources with an explicit call to the .close() coroutine. If you are using the exchange instance with async coroutines, add `await exchange.close()` to your code into a p

carlosmiei · 2024-04-18T10:12:01Z

fixed one issue, but found another crash

Traceback (most recent call last):
  File "/Users/cjg/Git/ccxt9/ccxt/examples/py/cli.py", line 249, in <module>
    asyncio.run(main())
  File "/opt/homebrew/Cellar/[email protected]/3.11.7_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/runners.py", line 190, in run
    return runner.run(main)
           ^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.7_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.11.7_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/asyncio/base_events.py", line 653, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/Users/cjg/Git/ccxt9/ccxt/examples/py/cli.py", line 228, in main
    result = await result
             ^^^^^^^^^^^^
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/pro/kucoinfutures.py", line 386, in watch_positions
    newPosition = await self.subscribe(url, messageHash, topic, None, self.extend(request, params))
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/pro/kucoinfutures.py", line 150, in subscribe
    return await self.watch(url, messageHash, message, subscriptionHash, subscription)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/async_support/base/ws/fast_client.py", line 26, in handler
    self.handle_message(message)
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/async_support/base/ws/aiohttp_client.py", line 34, in handle_message
    self.handle_text_or_binary_message(message.data)
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/async_support/base/ws/aiohttp_client.py", line 29, in handle_text_or_binary_message
    self.on_message_callback(self, decoded)
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/pro/kucoinfutures.py", line 1051, in handle_message
    method(client, message)
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/pro/kucoinfutures.py", line 999, in handle_subject
    method(client, message)
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/pro/kucoinfutures.py", line 523, in handle_position
    cache.append(position)
  File "/Users/cjg/Git/ccxt9/ccxt/python/ccxt/async_support/base/ws/cache.py", line 140, in append
    if item['id'] in by_id:
       ~~~~^^^^^^
KeyError: 'id'

pcriadoperez · 2024-04-23T09:40:38Z

good catch, it seems it was using the wrong type of array cache and was happening only when the position didn't exist in the first fetchPositons.

This also raised the issue I'm seeing we aren't handling the cache correctly for all non-hedged positions when newUpdates is false. I'll update the ArrayCache changes to this PR, so it serves as a working example, and once merged can check and fix the other exchanges.

…res-watchpositions

carlosmiei · 2024-04-27T14:12:15Z

@pcriadoperez you're missing updating the c# side here

…res-watchpositions

ts/src/base/ws/Cache.ts

carlosmiei · 2024-05-10T08:33:38Z

@pcriadoperez is this relevant for this pr?

feat(kucoinfutures): add watchPositions

9f1c1c9

pcriadoperez requested review from kroitor and frosty00 as code owners April 16, 2024 08:20

pcriadoperez self-assigned this Apr 16, 2024

pcriadoperez requested a review from carlosmiei April 16, 2024 08:20

pcriadoperez added 3 commits April 16, 2024 15:37

lint

7efd318

Merge branch 'master' of https://github.com/ccxt/ccxt into kucoinfutu…

68c078e

…res-watchpositions

update package.json

53652ef

pcriadoperez changed the title ~~feat(kucoinfutures): add watchPositions~~ feat(kucoinfutures): add watchPositions and upgrade ast-transpiler to v0.0.46 Apr 17, 2024

protect crash

ce64734

pcriadoperez added 2 commits April 24, 2024 02:55

fix cache

ee1092d

Merge branch 'master' of https://github.com/ccxt/ccxt into kucoinfutu…

1fc5494

…res-watchpositions

pcriadoperez added 4 commits April 27, 2024 23:03

add csharp

4f13a82

Merge branch 'master' of https://github.com/ccxt/ccxt into kucoinfutu…

beacb15

…res-watchpositions

lint

1e46ff6

fix python cache

6f001cd

carlosmiei reviewed Apr 29, 2024

View reviewed changes

ts/src/base/ws/Cache.ts Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(kucoinfutures): add watchPositions and upgrade ast-transpiler to v0.0.46 #22169

feat(kucoinfutures): add watchPositions and upgrade ast-transpiler to v0.0.46 #22169

pcriadoperez commented Apr 16, 2024 •

edited

carlosmiei commented Apr 18, 2024

carlosmiei commented Apr 18, 2024

pcriadoperez commented Apr 23, 2024

carlosmiei commented Apr 27, 2024

carlosmiei commented May 10, 2024

feat(kucoinfutures): add watchPositions and upgrade ast-transpiler to v0.0.46 #22169

Are you sure you want to change the base?

feat(kucoinfutures): add watchPositions and upgrade ast-transpiler to v0.0.46 #22169

Conversation

pcriadoperez commented Apr 16, 2024 • edited

carlosmiei commented Apr 18, 2024

carlosmiei commented Apr 18, 2024

pcriadoperez commented Apr 23, 2024

carlosmiei commented Apr 27, 2024

carlosmiei commented May 10, 2024

pcriadoperez commented Apr 16, 2024 •

edited