Skip to content

Conversation

@urwen
Copy link

@urwen urwen commented Nov 25, 2023

Firmware TEMPer1F_H1V1.5F (id 0c45:7402) seems to be using a different temperature sensor (SHT20). This change adds support for this sensor/firmware combination.

@urwen
Copy link
Author

urwen commented Nov 25, 2023

BTW, I have rebased all of your changes onto urwen/temper. There is one PR over there you should look at, because I think it's a one-line change to support another version: urwen#29

I want to thank you for forking temper and maintaining it for these past several years. I really appreciate it!!! I've put a note in my README.md to point to this repository, and I'll submit changes here if I add support for more devices.

@ccwienk
Copy link
Owner

ccwienk commented Jan 24, 2024

@urwen : npb. however, I think "maintaining" is giving me too much credit. basically, I forked it once to add a fix I needed, and then I actually almost forgot about the fork 🙈

I think I just caused a conflict by admitting another pullrequest that proposed the same change :(

@ccwienk
Copy link
Owner

ccwienk commented Jun 19, 2024

@urwen : I made you collaborator

@eode eode merged commit 5438aaa into ccwienk:master Sep 20, 2024
@eode
Copy link
Collaborator

eode commented Sep 20, 2024

@ccwienk @urwen I've just merged this branch -- I don't know if you two are active still, but just wanted to let you know.

Should we try to merge these two repos fully, and go with one over the other, going forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants