Upgrade pre-commit and its hooks #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeancochrane
commented
May 22, 2024
| @@ -13,4 +13,4 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| - name: Run pre-commit checks | |||
| uses: ccao-data/actions/pre-commit@main | |||
| uses: ./pre-commit | |||
There was a problem hiding this comment.
Switching to a relative path here should make development easier, since we don't need to update the ref to point to the current branch any time we want to test changes to the action.
Comment on lines
-22
to
-29
| - name: Permissions check on R cache (debugging) | ||
| run: > | ||
| if [ -d /home/runner/.cache/R ]; then | ||
| ls -lah /home/runner/.cache/R/R.cache | ||
| else | ||
| echo "Directory /home/runner/.cache/R/R.cache not exist." | ||
| fi | ||
| shell: bash |
There was a problem hiding this comment.
Based on my investigation in lorenzwalthert/precommit#571, this check is unnecessary, so I'm removing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of investigating lorenzwalthert/precommit#571, I realized that our pre-commit hooks are outdated, and we're running an old version of pre-commit due to installing from apt instead of PyPi. This PR updates pre-commit and its hooks for the sake of keeping things tidy and ruling out any problems due to package versions.
I also tested these changes as part of ccao-data/model-res-avm#243, to confirm that the R hooks still work.