-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text Search #893
Open
iddan
wants to merge
6
commits into
master
Choose a base branch
from
feature/search
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Text Search #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bleve will only be implemented for in-memory and key-value backends for now. |
dennwc
requested changes
Dec 13, 2019
dennwc
force-pushed
the
feature/search
branch
3 times, most recently
from
December 15, 2019 13:57
0056828
to
640ea2e
Compare
dennwc
force-pushed
the
feature/search
branch
from
January 18, 2020 10:49
7d20ebd
to
22c9730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVP implementation of text search based on Bleve. There are many capabilities not included in this PR but anything beyond the basic text search should be added in additional PRs.
Resolves #428
Tasks
search.Index()
andsearch.Delete()
for quads write and deletesearch.Configuration
to Cayley config file (and CLI?)This change is